Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JUnit 5 extension implementation for disabling Sauce #322

Closed
wants to merge 2 commits into from
Closed

Update JUnit 5 extension implementation for disabling Sauce #322

wants to merge 2 commits into from

Conversation

titusfortner
Copy link
Collaborator

@titusfortner titusfortner commented Sep 18, 2024 •
edited
Loading

One-line summary

Allows running locally while keeping Sauce Labs specific code

Description

  • Tests will fail until PR [java] update property name #320 is merged and Sauce Bindings 1.6.0 is released
  • Built snapshot jar of Sauce Bindings to verify this code works

Types of Changes

  • New feature (non-breaking change which adds functionality)

@nadvolod
Copy link
Contributor

@titusfortner looks like junit5 is still failing

@titusfortner
Copy link
Collaborator Author

This also needs a try/catch on the stop() method

@titusfortner
Copy link
Collaborator Author

Closing in favor of #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol Awaiting requested review from diemol

@nadvolod nadvolod Awaiting requested review from nadvolod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titusfortner @nadvolod