do not use empty string

saucelabs · Apr 5, 2024 · 8c0cf39 · 8c0cf39
1 parent 52768dd
commit 8c0cf39
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/playwright-runner.ts b/src/playwright-runner.ts
@@ -177,7 +177,7 @@ async function getCfg(
   runCfg.sauce.region = runCfg.sauce.region || 'us-west-1';
   runCfg.playwrightOutputFolder =
     suite.env?.SAUCE_SYNC_WEB_ASSETS?.toLowerCase() === 'true'
-      ? ''
+      ? undefined
       : path.join(runCfg.assetsDir, 'test-results');
 
   runCfg.webAssetsDir =

diff --git a/src/types.ts b/src/types.ts
@@ -27,9 +27,9 @@ export interface RunnerConfig {
   preExecTimeout: number;
   path: string;
   projectPath: string;
-  playwrightOutputFolder: string;
+  playwrightOutputFolder?: string;
   // webAssetsDir contains assets compatible with the Sauce Labs web UI.
-  webAssetsDir: string;
+  webAssetsDir?: string;
   suite: Suite;
 
   args: Record<string, unknown>;

diff --git a/src/utils.ts b/src/utils.ts
@@ -51,7 +51,9 @@ export function replaceLegacyKeys(config: SuiteConfig) {
   return args;
 }
 
-export function setEnvironmentVariables(envVars: Record<string, string> = {}) {
+export function setEnvironmentVariables(
+  envVars: Record<string, string | undefined> = {},
+) {
   if (!envVars) {
     return;
   }