Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove optional component included and executed from DaC #597

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

dhoucgitter
Copy link
Member

@dhoucgitter dhoucgitter commented Feb 27, 2025

Changes

Tests

  • Review the updated README, CONFIG-VARS.md and the other updated *.md files in the viya4-deployment GitHub PR chore: Remove optional component included and executed from DaC #597 to verify that any references related to using and support for the "viya-monitoring", "cluster-logging" and "cluster-monitoring" have been removed.

  • Using the updated DAC docker image, verify that specifying any of the three task tags related to monitoring and logging results in an Ansible task tag validation message and an immediate exit from DAC. The DAC "baseline" and "viya" task tags should be unaffected by the changes in this work item and either or both of those tags can continue to be used as before. Specifying any of the now unsupported logging and monitoring and task tags along with either of the valid tags will also result in a task validation error. As per the updates made to the AnsibleUsage.md file, a valid DAC install or uninstall command can no longer specify one or more of the task tags "viya-monitoring", "cluster-monitoring", or "cluster-logging".

  • Verify that using the "baseline,viya" install tasks successfully install the baseline dependencies and deploy Viya successfully.

@dhoucgitter dhoucgitter added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 27, 2025
@dhoucgitter dhoucgitter self-assigned this Feb 27, 2025
@dhoucgitter dhoucgitter marked this pull request as ready for review February 28, 2025 21:41
@dhoucgitter dhoucgitter requested a review from saschjmil March 3, 2025 18:22
Copy link
Contributor

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good call on adding a validation check for the unsupported tags.

@dhoucgitter dhoucgitter requested a review from illianov March 3, 2025 18:45
@dhoucgitter dhoucgitter merged commit 5dfc129 into staging Mar 3, 2025
4 checks passed
@dhoucgitter dhoucgitter deleted the pr-pskd-659 branch March 3, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants