Disallow passing functions/mixins across compilations#2544
Merged
Conversation
ntkme
force-pushed
the
disallow-compiler-function-mixin-across-compilations
branch
2 times, most recently
from
702f6a6 to
4b9ee73
Compare
ntkme
force-pushed
the
disallow-compiler-function-mixin-across-compilations
branch
from
4b9ee73 to
29d7ef1
Compare
nex3
approved these changes
May 5, 2025
nex3
force-pushed
the
disallow-compiler-function-mixin-across-compilations
branch
from
2547c76 to
7816348
Compare
ntkme
force-pushed
the
disallow-compiler-function-mixin-across-compilations
branch
from
7816348 to
d1320ae
Compare
ntkme
commented
May 8, 2025
Comment on lines
1
to
+2
| ## 1.88.1-dev | ||
|
|
||
| * **Potentially breaking bug fix:** Throw an error when passing a function or | ||
| mixin from one compilation to another. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@nex3 Looks like 1.88.0 was never released?
Contributor
There was a problem hiding this comment.
Huh, I guess I forgot to kick off a release. Thanks for noticing.
nex3
force-pushed
the
disallow-compiler-function-mixin-across-compilations
branch
3 times, most recently
from
b548b09 to
230d01f
Compare
nex3
force-pushed
the
disallow-compiler-function-mixin-across-compilations
branch
from
230d01f to
71da3ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2542
sass/embedded-host-node#367
sass/sass-spec#2053