Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement first class mixins #2073

Merged
merged 36 commits into from
Oct 5, 2023
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
ef23769
initial impl of first class mixins
connorskees Aug 25, 2023
0b9f3a8
add mixin type to js api
connorskees Aug 26, 2023
63c1f5e
add first class mixins to embedded protocol
connorskees Aug 26, 2023
f9badfa
support AsyncBuiltInCallable in accepts-content
connorskees Aug 26, 2023
010ad35
generate evaluate file
connorskees Aug 26, 2023
b908e27
bump ci
connorskees Aug 29, 2023
7d6757c
merge main
connorskees Sep 1, 2023
f715c22
revert embedded protocol changes
connorskees Sep 2, 2023
c0eced3
Style nits
nex3 Sep 6, 2023
91ac279
some pr review
connorskees Sep 7, 2023
194e171
Revert "revert embedded protocol changes"
connorskees Sep 7, 2023
154e12e
remove redundant content cast
connorskees Sep 8, 2023
ca57cb0
correctly pass content through meta.apply
connorskees Sep 8, 2023
4093914
correctly pass through acceptsContent value
connorskees Sep 8, 2023
eb33c56
pr review
connorskees Sep 14, 2023
eeb14ee
refactor embedded registry
connorskees Sep 14, 2023
1cfd14b
merge main
connorskees Sep 14, 2023
5e1774c
merge main
connorskees Sep 16, 2023
faba24a
await _applyMixin
connorskees Sep 19, 2023
52a1e6f
Merge branch 'main' of https://github.com/sass/dart-sass into feat/fi…
connorskees Sep 20, 2023
ff3d80e
Merge branch 'main' of https://github.com/sass/dart-sass into feat/fi…
connorskees Sep 21, 2023
89ef731
add doc comment to _applyMixin
connorskees Sep 21, 2023
93b812a
run synchronize
connorskees Sep 22, 2023
6e85d50
bump ci
connorskees Sep 25, 2023
2738c00
merge main
connorskees Sep 26, 2023
80fd8bb
Update pubspec and changelog
nex3 Sep 28, 2023
9485b4f
merge main
connorskees Sep 29, 2023
3144e02
nits
connorskees Sep 30, 2023
f1c1d5a
lazily evaluate file spans
connorskees Oct 3, 2023
895b2ca
Merge branch 'main' of https://github.com/sass/dart-sass into feat/fi…
connorskees Oct 3, 2023
96bbca2
bump ci
connorskees Oct 3, 2023
679e1bd
bump ci
connorskees Oct 4, 2023
65f2d2d
Merge branch 'main' of https://github.com/sass/dart-sass into feat/fi…
connorskees Oct 4, 2023
75ccdfb
take Object self in JS constructor
connorskees Oct 4, 2023
6277d5d
bump ci
connorskees Oct 4, 2023
f1b4ff3
add SassMixin to ESM export
connorskees Oct 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
run synchronize
connorskees committed Sep 22, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 93b812abc52b2610b7cbaa14e92742793221a53b
3 changes: 2 additions & 1 deletion lib/src/visitor/evaluate.dart
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
// DO NOT EDIT. This file was generated from async_evaluate.dart.
// See tool/grind/synchronize.dart for details.
//
// Checksum: 61f8aeb4df0e1a3e236d824dbdd934f325978090
// Checksum: 0985a8b7386d8784bf7cb08a0337b9b81deb5bbe
//
// ignore_for_file: unused_import

@@ -1782,6 +1782,7 @@ final class _EvaluateVisitor
}
}

/// Evaluate a given [mixin] with [arguments] and [contentCallable]
void _applyMixin(
Callable? mixin,
UserDefinedCallable<Environment>? contentCallable,