-
Notifications
You must be signed in to change notification settings - Fork 24
Be able to go to home page after games end. #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… all the games. Renamed the classes so that the JavaScript wouldn't affect the home button, so styles and JavaScript are different.
✅ Deploy Preview for webgames02 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @haddeeann, Thank you so much for the pull request 😊 |
|
All the games. I added a 'go home' button to all of them. I like the idea of the project and just wanted some way to contribute. |
|
hi @haddeeann 👋 But here is one thing to consider, |
|
I will check that out tonite. I'm not sure why it didn't register that it
opened in a new tab! I agree with you.
If the game goes home it shouldn't open a new tab for a game.
…On Wed, Jan 17, 2024, 1:47 AM Shah Sarmad Hamdani ***@***.***> wrote:
hi @haddeeann <https://github.com/haddeeann> 👋
I really liked this idea and also reviewed the PR, it is great👏
But here is one thing to consider,
Once we click on the game icon on the home page, the game opens in another
tab. The reason is simple to make it easy for the user to return to the
home page. Now, if we add a home button, this button will bring us to the
home screen on the same tab, in this way if the user keeps playing the
games once by one it will keep opening the tabs and waste the device's
memory. One thing we can do is instead of opening games on another tab,
open them on the same tab.
What do you think about this idea?
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APMVFXYNZF3UEAFDLW4YBNTYO5XWPAVCNFSM6AAAAABBBUMGFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVGEZDENRRHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…n the same window we don't have to open in a new tab
|
Lols, sorry it took me so long to update the PR :) I'm very happy to be able to contribute!! |
I noticed that after playing the game there was no way to go 'home'. This seemed like a feature that I would want as a player. I changed the classes around a little bit for the end game buttons so the JavaScript uses something different to end the game vs the CSS class.
That way the CSS will be the same for 'home' button and 'replay' buttons. But the JavaScript will be different.
I could be wrong, but I've always just seen the git ignore file without a .txt extension.