Skip to content

Conversation

@ChaviSchatz
Copy link

Hi!
In the meantime, I changed the Dark Mode button - which will change to Light Mode when pressed.

@sarmadhamdani02
Copy link
Owner

Hi @ChaviSchatz 👋
Thanks for the PR.

If you are talking about the icon below,
image

Then, it can be a good idea. But I think in this way we should increase the size of the icon a bit in order to make it a bit more appealing. 🤔

@ChaviSchatz
Copy link
Author

Sorry I didn't consider mobile mode but only computer mode. I will work on it
Thanks!

@sarmadhamdani02
Copy link
Owner

I apologize, but I'm having trouble understanding the purpose of this PR. Could you please explain?

@ChaviSchatz
Copy link
Author

Yes, sorry I wasn't clear.
What I did is that when you click on Dark Mode, the screen goes dark.
So instead of it now being written Dark Mode to make it bright I changed it to Light Mode which will become bright.
I did it. Interested in it?

@ChaviSchatz
Copy link
Author

Attached photos. You will understand more what I meant.

Dark Mode
Light Mode

@sarmadhamdani02
Copy link
Owner

sarmadhamdani02 commented Oct 2, 2023

Ok, thank you so much for the clarification. 😊
I will soon review the PR and will let you know if there is any change required.

@sarmadhamdani02
Copy link
Owner

Hi there 👋
Just saw the latest changes made. I don't really think that changing that background and tic-tac-toe's thumbnail is really necessary. 🤔
What do you say?

@ChaviSchatz
Copy link
Author

I thought it might add to the visibility of the page.
But of course not necessary...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants