Enforce maxRating limit in RatingBar value calculation #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear sarbagyastha
Issue:
We observed that tapping on the rating bar could inadvertently allow users to set a rating higher than the
maxRating
, which should not be possible. This inconsistency can lead to unexpected behavior, particularly when a specificmaxRating
is set.Implemented Fix:
To resolve this, I have adjusted the rating calculation logic to ensure that the rating value does not go beyond
maxRating
when the widget is tapped. The key change is:Here is a video of the issue
Enforce.maxRating.limit.in.RatingBar.value.calculation.2024-01-13.23.44.43.mov
Thank you for your time.