Repository navigation
collection: Update sample playbooks and remove deprecated variables - #1255
Open
marcelmamula wants to merge 2 commits into
Open
marcelmamula wants to merge 2 commits into
marcelmamula wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Premise
Sample playbooks contain lot of variables that were deprecated and we should not be advertising them.
Changes
sap_swpmand add dedicated playbooks for execution scenarios that will be properly defined in upcomingsap_swpmPR.ansible.playbooks_for_sapas source for end to end playbooks, not here.NOTE for
sap_hana_preconfigure_exec.ymlThe playbook
sap_hana_preconfigure_exec.ymlwas removed without any replacement, because its implementation had following issues:ansible.builtin.import_playbookdoes not work on 2.18 - 2.21 versions@berndfinger I think having good samples has more value, but maybe you can say if you added it for some specific reason. Then I can re-add it, but only if it is working properly.