Skip to content

feat(desktop): add collection-level type choice - #63

Merged
santosli merged 2 commits into
mainfrom
codex/collection-type-choice
Aug 19, 2026
Merged

feat(desktop): add collection-level type choice#63
santosli merged 2 commits into
mainfrom
codex/collection-type-choice

Conversation

@santosli

@santosli santosli commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • move User/Remote classification for collection imports into one header-level radiogroup
  • apply the chosen type to every actionable child in the complete collection and select those children, while preserving imported/system/conflict/read-only state
  • block collection eligibility, global selection counts, child selection, and final apply requests while actionable child types are unresolved or mixed
  • keep standalone skill type controls and per-child import requests unchanged
  • document and test full-collection, accessibility, selection, managed-type, and submit-path boundaries

Verification

  • node --test apps/desktop/src/App.import-candidates.test.js apps/desktop/src/cardLayout.test.js (162 passed)
  • npm test (280 passed)
  • npm --workspace apps/desktop run build
  • npm audit --audit-level=high (0 vulnerabilities)
  • git diff --check
  • visual QA at 1600x900 and 1000x760 with 0px document horizontal overflow

Visual evidence

  • /tmp/skillbox-collection-type-required-blocked-1600.png
  • /tmp/skillbox-collection-type-resolved-user-1600.png
  • /tmp/skillbox-collection-type-user-1600.png
  • /tmp/skillbox-collection-type-remote-1600.png
  • /tmp/skillbox-collection-type-narrow-1000.png

No Rust, Tauri, filesystem, Git, or import-apply contract changes.

@santosli
santosli marked this pull request as ready for review August 19, 2026 16:01
@santosli
santosli merged commit c297f46 into main Aug 19, 2026
2 checks passed
@santosli
santosli deleted the codex/collection-type-choice branch August 19, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant