Conversation
fa196f4 to
377f3c4
Compare
…dd new category alert type infered from schema
36ae804 to
17769cf
Compare
# Conflicts: # package.json # pnpm-lock.yaml # src/lib/ui/app/Alerts/categories/screener/screener-form-step/schema.ts
21b4d5f to
de6ccf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added integration tests for Alerts creation.
Currently, the following types of tests are included:
Render the dialog component with a given alert prop and verify that:
Call mutateSaveAlert (and mutateDeleteAlert afterward for cleanup) with the same alert shape as in the UI tests, verifying that the backend successfully accepts it.
There are some considerations/proposals about testing:
@DmitriVanGuard @serafim-san Feel free to comment here your thoughts about it if you have any
In my opinion, it’s better to minimize direct calls to the real API in tests.
Here’s a proposal for replacing integration tests with more focused unit tests, while still ensuring backend compatibility: