Open
Conversation
DmitriVanGuard
requested changes
Jan 18, 2023
Comment on lines
82
to
93
| async function setInsightItems() { | ||
| if (activeMenu !== MenuItem.TRENDING) return | ||
| const insightItems = await queryExplorerItems({ | ||
| types: [EntityKeys.INSIGHT], | ||
| page: insightsPage, | ||
| }) | ||
| insightsPages = insightItems.pages | ||
| insights = insightsPage === 1 ? insightItems.items : insights.concat(insightItems.items) | ||
| } | ||
|
|
||
| async function setDisplayingItems() { | ||
| const displayingItems = await queryExplorerItems({ |
Member
There was a problem hiding this comment.
As @Woafflation described, separate insights' query was added as hotfix to support insights in the feed. Now it is not required, since it's natively supported by the api.
app/src/pages/Explorer/Category/ExplorerCategory.svelte
Lines 91 to 104 in b5b94db
The inisght specific query function can be removed (LOC 82)
DmitriVanGuard
approved these changes
Jan 19, 2023
Member
DmitriVanGuard
left a comment
There was a problem hiding this comment.
I will merge this PR a little bit later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Notion's card
Checklist
Screenshots or GIFs