Skip to content

replace avg_logFC to avg_log2FC in multiple files#130

Open
ladakoneva wants to merge 2 commits intomasterfrom
fix_avg_logFC
Open

replace avg_logFC to avg_log2FC in multiple files#130
ladakoneva wants to merge 2 commits intomasterfrom
fix_avg_logFC

Conversation

@ladakoneva
Copy link
Copy Markdown
Collaborator

No description provided.

@ladakoneva ladakoneva requested a review from snsansom November 30, 2021 20:16
@ladakoneva ladakoneva closed this Dec 1, 2021
@ladakoneva ladakoneva deleted the fix_avg_logFC branch December 1, 2021 11:36
@ladakoneva ladakoneva restored the fix_avg_logFC branch December 1, 2021 11:53
@ladakoneva ladakoneva reopened this Dec 1, 2021
Copy link
Copy Markdown
Contributor

@snsansom snsansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit simply does s/avg_logFC/avg_log2FC.

However in quite a few places we work with the avg_logFC either setting thresholds or un-logging with expm1 etc. So it is not as simple as this and the result is that the code in this branch introduces errors into the analysis. It should not be used for analyses being prepared for publication.

For now I will use a simpler approach which is to change the default base for FindMarkers (see the sns_seurat_4_compatiblity branch). In practise for us this is fine because we have already been careful to convert to log2 when it makes sense for plotting. However if you would like to go through and change all the thresholds & re-write the interconversions between bases (which would be good to make code simpler) etc I will be happy to accept a future request.

Thanks, S.

@snsansom snsansom added bug Something isn't working invalid This doesn't seem right and removed bug Something isn't working labels Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants