replace avg_logFC to avg_log2FC in multiple files#130
replace avg_logFC to avg_log2FC in multiple files#130ladakoneva wants to merge 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
This commit simply does s/avg_logFC/avg_log2FC.
However in quite a few places we work with the avg_logFC either setting thresholds or un-logging with expm1 etc. So it is not as simple as this and the result is that the code in this branch introduces errors into the analysis. It should not be used for analyses being prepared for publication.
For now I will use a simpler approach which is to change the default base for FindMarkers (see the sns_seurat_4_compatiblity branch). In practise for us this is fine because we have already been careful to convert to log2 when it makes sense for plotting. However if you would like to go through and change all the thresholds & re-write the interconversions between bases (which would be good to make code simpler) etc I will be happy to accept a future request.
Thanks, S.
No description provided.