Initial refactoring#3

Open

JonahHouseKin wants to merge 285 commits intosandimetz:mainfrom JonahHouseKin:refactoring-example

+244

This pull request is big! We're only showing the most recent 250 commits

Commits on Oct 12, 2020

song test sandimetz#3 -just write it down

skmetz
authored and
Katrina Owen
committed
add case 6/7 to verse

skmetz
authored and
Katrina Owen
committed
revert case 6/7

skmetz
authored and
Katrina Owen
committed
interpolate number in 2 case

skmetz
authored and
Katrina Owen
committed
fling entire container method in

skmetz
authored and
Katrina Owen
committed
revert prior change

skmetz
authored and
Katrina Owen
committed
add empty container method

skmetz
authored and
Katrina Owen
committed
return 'bottles' in container

skmetz
authored and
Katrina Owen
committed
send #container in default

skmetz
authored and
Katrina Owen
committed
add defaulted arg to container

skmetz
authored and
Katrina Owen
committed
add entire conditional to container

skmetz
authored and
Katrina Owen
committed
pass arg when sending #container

skmetz
authored and
Katrina Owen
committed
use #container in 2 case

skmetz
authored and
Katrina Owen
committed
remove obsolete default arg

skmetz
authored and
Katrina Owen
committed
delete obsolete 2 case

skmetz
authored and
Katrina Owen
committed
interpolate number at start of 1 case

skmetz
authored and
Katrina Owen
committed
send #container in phrase 1 case 1

skmetz
authored and
Katrina Owen
committed
make phrase 1/2 of case 1/else identical

skmetz
authored and
Katrina Owen
committed
add pronoun

skmetz
authored and
Katrina Owen
committed
pronoun returns 'one'

skmetz
authored and
Katrina Owen
committed
send pronoun in else

skmetz
authored and
Katrina Owen
committed
add defaulted arg to pronoun

skmetz
authored and
Katrina Owen
committed
use pronoun arg in if statement

skmetz
authored and
Katrina Owen
committed
pass arg to pronoun in else

skmetz
authored and
Katrina Owen
committed
use pronoun arg in 1 case

skmetz
authored and
Katrina Owen
committed
remove obsolete arg from pronoun

skmetz
authored and
Katrina Owen
committed
add quantity

skmetz
authored and
Katrina Owen
committed
quantity returns 'no more'

skmetz
authored and
Katrina Owen
committed
1 case sends quantity

skmetz
authored and
Katrina Owen
committed
add arg and wrong default to quantity

skmetz
authored and
Katrina Owen
committed
use wrong default in quantity conditional

skmetz
authored and
Katrina Owen
committed
revert to green

skmetz
authored and
Katrina Owen
committed
set quantity arg default to correct value

skmetz
authored and
Katrina Owen
committed
use correct default in quantity conditional

skmetz
authored and
Katrina Owen
committed
send quantity(arg) in case 1 phrase 4

skmetz
authored and
Katrina Owen
committed
send quantity(arg) in else phrase 4

skmetz
authored and
Katrina Owen
committed
remove obsolete default

skmetz
authored and
Katrina Owen
committed
send container in case 1 phrase 4

skmetz
authored and
Katrina Owen
committed
delete case 1

skmetz
authored and
Katrina Owen
committed
send quantity in case 0 phrase 1

skmetz
authored and
Katrina Owen
committed
send quantity in else phrase 1, FAILS

skmetz
authored and
Katrina Owen
committed
hack to_s in else case to sidestep error

skmetz
authored and
Katrina Owen
committed
add unneeded to_s to 1 case to make them the same

skmetz
authored and
Katrina Owen
committed
add to_s to #quantity, return a capitalizable

skmetz
authored and
Katrina Owen
committed
remove obsolete to_s's

skmetz
authored and
Katrina Owen
committed
send container in case 0 phrase 1

skmetz
authored and
Katrina Owen
committed
send quantity in else phrase 2

skmetz
authored and
Katrina Owen
committed
make case 0 phrase 2 like else phrase 2

skmetz
authored and
Katrina Owen
committed
add complete #action

skmetz
authored and
Katrina Owen
committed
use #action

skmetz
authored and
Katrina Owen
committed
send #quantity(99)

skmetz
authored and
Katrina Owen
committed
send container in case 0 phrase 4

skmetz
authored and
Katrina Owen
committed
add #successor(number)

skmetz
authored and
Katrina Owen
committed
send #successor in else phrase 4

skmetz
authored and
Katrina Owen
committed
add conditional to #successor

skmetz
authored and
Katrina Owen
committed
replace 99 with successor(number)

skmetz
authored and
Katrina Owen
committed
use successor everywhere

skmetz
authored and
Katrina Owen
committed
try common template

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
wrap long lines in verse

skmetz
authored and
Katrina Owen
committed
add empty BottleNumber class

skmetz
authored and
Katrina Owen
committed
copy obsessive methods to BottleNumber

skmetz
authored and
Katrina Owen
committed
add attr_reader and initializer

skmetz
authored and
Katrina Owen
committed
parse/exec BottleNumber#quantity

skmetz
authored and
Katrina Owen
committed
use BottleNumber#quantity result

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
parse/exec BottleNumber#container

skmetz
authored and
Katrina Owen
committed
use BottleNumber#container result

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
parse/exec BottleNumber#action

skmetz
authored and
Katrina Owen
committed
use BottleNumber#action result

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
parse/exec BottleNumber#pronoun

skmetz
authored and
Katrina Owen
committed
use BottleNumber#pronoun result

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
parse/exec BottleNumber#successor

skmetz
authored and
Katrina Owen
committed
use BottleNumber#successor result

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
rename BottleNumber#quantity argument

skmetz
authored and
Katrina Owen
committed
remove param from sender

skmetz
authored and
Katrina Owen
committed
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
rename BottleNumber#container argument

skmetz
authored and
Katrina Owen
committed
remove param from sender

skmetz
authored and
Katrina Owen
committed
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
rename BottleNumber#action argument

skmetz
authored and
Katrina Owen
committed
remove param from sender

skmetz
authored and
Katrina Owen
committed
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
rename BottleNumber#pronoun argument

skmetz
authored and
Katrina Owen
committed
remove param from unused sender

skmetz
authored and
Katrina Owen
committed
remove arg from receiver FAIL

skmetz
authored and
Katrina Owen
committed
revert prior change

skmetz
authored and
Katrina Owen
committed
delete unused Bottles#pronoun

skmetz
authored and
Katrina Owen
committed
remove param from sender

skmetz
authored and
Katrina Owen
committed
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
rename BottleNumber#successor argument

skmetz
authored and
Katrina Owen
committed
remove param from sender

skmetz
authored and
Katrina Owen
committed
remove arg from receiver

skmetz
authored and
Katrina Owen
committed
cache (memoize) a BottleNumber

skmetz
authored and
Katrina Owen
committed
send #action to bottle_number

skmetz
authored and
Katrina Owen
committed
use bottle_number is phrase 1

skmetz
authored and
Katrina Owen
committed
use bottle_number is phrase 2

skmetz
authored and
Katrina Owen
committed
cache (memoize) the next BottleNumber

skmetz
authored and
Katrina Owen
committed
use next_bottle_number is phrase 4

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
add BottleNumber#to_s

skmetz
authored and
Katrina Owen
committed
use to_s in phrase 1

skmetz
authored and
Katrina Owen
committed
use to_s in phrase 2

skmetz
authored and
Katrina Owen
committed
use to_s in phrase 4

skmetz
authored and
Katrina Owen
committed
unite phrase 1 on single line

skmetz
authored and
Katrina Owen
committed
consolidate phrase 1 strings

skmetz
authored and
Katrina Owen
committed
unite phrase 4 on single line

skmetz
authored and
Katrina Owen
committed
consolidate phrase 4 strings

skmetz
authored and
Katrina Owen
committed
create BottleNumber0 class

skmetz
authored and
Katrina Owen
committed
copy #quantity to BottleNumber0

skmetz
authored and
Katrina Owen
committed
reduce #quantity to specialization

skmetz
authored and
Katrina Owen
committed
add #bottle_number_for

skmetz
authored and
Katrina Owen
committed
use #bottle_number_for once

skmetz
authored and
Katrina Owen
committed
use #bottle_number_for twice

skmetz
authored and
Katrina Owen
committed
manufacture a bottle number

skmetz
authored and
Katrina Owen
committed
parse an alternate factory impl

skmetz
authored and
Katrina Owen
committed
use the alternate implementation

skmetz
authored and
Katrina Owen
committed
reduce super #quantity to generalization

skmetz
authored and
Katrina Owen
committed
copy #action to BottleNumber0

skmetz
authored and
Katrina Owen
committed
return specialization

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
return super's generalization

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
copy #successor to BottleNumber0

skmetz
authored and
Katrina Owen
committed
return specialization

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
return super's generalization

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
create BottleNumber1 class

skmetz
authored and
Katrina Owen
committed
copy #container to BottleNumber1

skmetz
authored and
Katrina Owen
committed
return specialization

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
return super's generalization FAIL

skmetz
authored and
Katrina Owen
committed
revert previous change

skmetz
authored and
Katrina Owen
committed
parse updated factory

skmetz
authored and
Katrina Owen
committed
use updated factory

skmetz
authored and
Katrina Owen
committed
return super's #container generalization

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
copy #pronoun to BottleNumber1

skmetz
authored and
Katrina Owen
committed
return specialization

skmetz
authored and
Katrina Owen
committed
return super's generalization

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
wish for a smarter successor

skmetz
authored and
Katrina Owen
committed
copy #bottle_number_for to BottleNumber.for

skmetz
authored and
Katrina Owen
committed
use .for factory once

skmetz
authored and
Katrina Owen
committed
use .for factory twice

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
add type check guard clause to BottleNumber.for

skmetz
authored and
Katrina Owen
committed
return a bottle number from BottleNumber0#successor

skmetz
authored and
Katrina Owen
committed
return a bottle number from BottleNumber#successor

skmetz
authored and
Katrina Owen
committed
see if the successor wish now works

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
inline next_bottle_number temp

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
add six-pack to song test

skmetz
authored and
Katrina Owen
committed
create BottleNumber6 class

skmetz
authored and
Katrina Owen
committed
add BottleNumber6#container

skmetz
authored and
Katrina Owen
committed
add BottleNumber6 to factory

skmetz
authored and
Katrina Owen
committed
add BottleNumber6#quantity

skmetz
authored and
Katrina Owen
committed
parse metaprogrammed factory

skmetz
authored and
Katrina Owen
committed
use metaprogrammed factory

skmetz
authored and
Katrina Owen
committed
parse Hash factory

skmetz
authored and
Katrina Owen
committed
use Hash factory

skmetz
authored and
Katrina Owen
committed
add handles? method to BottleNumber6

skmetz
authored and
Katrina Owen
committed
add handles? method to BottleNumber1

skmetz
authored and
Katrina Owen
committed
add handles? method to BottleNumber0

skmetz
authored and
Katrina Owen
committed
add handles? method to BottleNumber

skmetz
authored and
Katrina Owen
committed
parse dispersed choosing logic factory

skmetz
authored and
Katrina Owen
committed
use dispersed choosing logic factory

skmetz
authored and
Katrina Owen
committed
add BottleNumber.registry

skmetz
authored and
Katrina Owen
committed
add BottleNumber.register

skmetz
authored and
Katrina Owen
committed
register BottleNumber6

skmetz
authored and
Katrina Owen
committed
register BottleNumber1

skmetz
authored and
Katrina Owen
committed
register BottleNumber0

skmetz
authored and
Katrina Owen
committed
register BottleNumber

skmetz
authored and
Katrina Owen
committed
parse self registering factory

skmetz
authored and
Katrina Owen
committed
use self registering factory

skmetz
authored and
Katrina Owen
committed
override inherited hook

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
initialize registry with BottleNumber

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
revert to simplest factory

skmetz
authored and
Katrina Owen
committed
create BottleVerse class

skmetz
authored and
Katrina Owen
committed
add attr_reader and initialize number

skmetz
authored and
Katrina Owen
committed
copy #verse from Bottles to BottleVerse

skmetz
authored and
Katrina Owen
committed
parse/exec new #verse from old #verse

skmetz
authored and
Katrina Owen
committed
use result of new #verse

skmetz
authored and
Katrina Owen
committed
revert to old #verse

skmetz
authored and
Katrina Owen
committed
wish to send #lyrics

skmetz
authored and
Katrina Owen
committed
change BottleVerse#verse(number) to BottleVerse#lyrics

skmetz
authored and
Katrina Owen
committed
parse/exec sending #lyrics

skmetz
authored and
Katrina Owen
committed
use result of sending #lyrics

skmetz
authored and
Katrina Owen
committed
wish to depend of verse template role

skmetz
authored and
Katrina Owen
committed
inject verse_template role

skmetz
authored and
Katrina Owen
committed
use result from verse template role

skmetz
authored and
Katrina Owen
committed
wish for lyrics without Demeter violation

skmetz
authored and
Katrina Owen
committed
add BottleVerse.lyrics to make wish possible

skmetz
authored and
Katrina Owen
committed
retrieve lyrics without Demeter violation

skmetz
authored and
Katrina Owen
committed
wish to consolidate object creation

skmetz
authored and
Katrina Owen
committed
lyrics works with numbers or bottle numbers

skmetz
authored and
Katrina Owen
committed
parse/exec wish

skmetz
authored and
Katrina Owen
committed
use result of consolidated object creation wish

skmetz
authored and
Katrina Owen
committed
remove number to bottle number conversion from #lyrics

skmetz
authored and
Katrina Owen
committed
add bottle_number attr_reader

skmetz
authored and
Katrina Owen
committed
initialize bottle_number

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
add alternate initializer

skmetz
authored and
Katrina Owen
committed
use alternate initializer

skmetz
authored and
Katrina Owen
committed
delete obsolete code

skmetz
authored and
Katrina Owen
committed
add BottleVerseTest

skmetz
authored and
Katrina Owen
committed
copy 1st test from BottlesTest to BottleVerseTest

skmetz
authored and
Katrina Owen
committed
use BottleVerse in 1st test

skmetz
authored and
Katrina Owen
committed
delete obsolete test

skmetz
authored and
Katrina Owen
committed
copy all other verse tests into BottleVerseTest

skmetz
authored and
Katrina Owen
committed
make 1 undo regexp change from Bottles to BottleVerse

skmetz
authored and
Katrina Owen
committed
delete obsolete test

skmetz
authored and
Katrina Owen
committed
rename lower bound test

skmetz
authored and
Katrina Owen
committed
rename upper bound test

skmetz
authored and
Katrina Owen
committed
add verse 7 test

skmetz
authored and
Katrina Owen
committed
add verse 6 test

skmetz
authored and
Katrina Owen
committed
duplicate Bottles as CountdownSong

skmetz
authored and
Katrina Owen
committed
change BottlesTest to CountdownSongTest

skmetz
authored and
Katrina Owen
committed
change Bottles to CountdownSong (1 undo change)

skmetz
authored and
Katrina Owen
committed
delete obsolete Bottles class

skmetz
authored and
Katrina Owen
committed
add VerseFake

skmetz
authored and
Katrina Owen
committed
create alternate test_a_couple_verses method

skmetz
authored and
Katrina Owen
committed
use VerseFake in alternate couple_verses test

skmetz
authored and
Katrina Owen
committed
delete obsolete test

skmetz
authored and
Katrina Owen
committed
delete redundant test_a_few_verses

skmetz
authored and
Katrina Owen
committed
add verse test

skmetz
authored and
Katrina Owen
committed
rename verses test

skmetz
authored and
Katrina Owen
committed
create max and min attr_readers

skmetz
authored and
Katrina Owen
committed
initialize max and min

skmetz
authored and
Katrina Owen
committed
use max and min in #song

skmetz
authored and
Katrina Owen
committed
add alternate #test_the_whole_song

skmetz
authored and
Katrina Owen
committed
delete obsolete test

skmetz
authored and
Katrina Owen
committed
rename song test

skmetz
authored and
Katrina Owen
committed
move VerseFake to top of file

skmetz
authored and
Katrina Owen
committed
add verse role test

skmetz
authored and
Katrina Owen
committed
set @role_player in BotttleVerseTest#setup

skmetz
authored and
Katrina Owen
committed
include VerseRoleTest in BottleVerseTest

skmetz
authored and
Katrina Owen
committed
create VerseFakeTest

skmetz
authored and
Katrina Owen
committed
remove verse_template default

skmetz
authored and
Katrina Owen
committed
set max default to 999999

skmetz
authored and
Katrina Owen
committed

Commits on Jan 20, 2024

Initial refactoring
JonahHouseKin
committed