Merge pull request #19 from samsonasik/bump-php82

Bump php requirement to php 8.2, add php 8.4 support

.github/workflows/ci_build.yaml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-versions: ['8.1', '8.2']
+        php-versions: ['8.2', '8.3', '8.4']
     steps:
       - name: Setup PHP Action
         uses: shivammathur/setup-php@v2

composer.json

@@ -18,16 +18,16 @@
         }
     ],
     "require": {
-        "php": "~8.1.0 || ~8.2.0 || ~8.3.0"
+        "php": "~8.2.0 || ~8.3.0 || ~8.4.0"
     },
     "conflict": {
-        "codeigniter4/framework": "<4.5.1"
+        "codeigniter4/framework": "<4.6"
     },
     "require-dev": {
-        "codeigniter/coding-standard": "^1.7.15",
-        "codeigniter4/framework": "^4.5.1",
-        "phpstan/phpstan": "^2.0",
-        "phpunit/phpunit": "^10.5.20",
+        "codeigniter/coding-standard": "^1.8.2",
+        "codeigniter4/framework": "^4.6",
+        "phpstan/phpstan": "^2.0.4",
+        "phpunit/phpunit": "^11.5.2",
         "rector/rector": "dev-main"
     },
     "config": {

rector.php

@@ -21,7 +21,8 @@
         naming: true,
         codingStyle: true
     )
-    ->withPhpSets(php81: true)
+    ->withPhpSets(php82: true)
+    ->withComposerBased(phpunit: true)
     ->withPaths([__DIR__ . '/src', __DIR__ . '/test'])
     ->withRootFiles()
     ->withImportNames(removeUnusedImports: true)

src/Config/Services.php

@@ -46,7 +46,7 @@ public static function albumTrackSummary(bool $getShared = true): SQLAlbumTrackS
 
         return new SQLAlbumTrackSummaryRepository(
             model(AlbumModel::class),
-            model(TrackModel::class)
+            model(TrackModel::class),
         );
     }
 }

src/Domain/Album/AlbumNotFoundException.php

@@ -19,7 +19,7 @@ public static function forAlbumDoesnotExistOfId(int $id): self
     {
         return new self(sprintf(
             'The album with album ID %d you requested does not exist.',
-            $id
+            $id,
         ));
     }
 }

src/Domain/Track/TrackDuplicatedRectorException.php

@@ -19,7 +19,7 @@ public static function forDuplicatedTitle(int $id): self
     {
         return new self(sprintf(
             'The track with album id %d has duplicated title.',
-            $id
+            $id,
         ));
     }
 }

src/Domain/Track/TrackNotFoundException.php

@@ -19,7 +19,7 @@ public static function forAlbumTrackDoesnotExistOfId(int $id): self
     {
         return new self(sprintf(
             'The album track with track ID %d you requested does not exist.',
-            $id
+            $id,
         ));
     }
 }

src/Infrastructure/Persistence/Album/SQLAlbumRepository.php

@@ -18,7 +18,7 @@
 use Album\Infrastructure\Persistence\DMLPersistence;
 use Album\Models\AlbumModel;
 
-final class SQLAlbumRepository implements AlbumRepository
+final readonly class SQLAlbumRepository implements AlbumRepository
 {
     use DMLPersistence;
 

src/Infrastructure/Persistence/AlbumTrackSummary/SQLAlbumTrackSummaryRepository.php

@@ -17,9 +17,9 @@
 use Album\Models\AlbumModel;
 use Album\Models\TrackModel;
 
-final class SQLAlbumTrackSummaryRepository implements AlbumTrackSummaryRepository
+final readonly class SQLAlbumTrackSummaryRepository implements AlbumTrackSummaryRepository
 {
-    public function __construct(private readonly AlbumModel $albumModel, private readonly TrackModel $trackModel)
+    public function __construct(private AlbumModel $albumModel, private TrackModel $trackModel)
     {
     }
 

src/Infrastructure/Persistence/Track/SQLTrackRepository.php

@@ -21,7 +21,7 @@
 use Album\Models\TrackModel;
 use Config\Services;
 
-final class SQLTrackRepository implements TrackRepository
+final readonly class SQLTrackRepository implements TrackRepository
 {
     use DMLPersistence {
         save as saveData;

test/Database/Infrastructure/Persistence/Track/SQLTrackRepositoryTest.php

@@ -165,7 +165,7 @@ public function testSaveDuplicateDataInsert(): void
                 'album_id' => 1,
                 'title'    => 'Sahabat Sejati',
                 'author'   => 'Erros Chandra',
-            ]
+            ],
         ));
 
         $this->expectException(DuplicatedRecordException::class);
@@ -174,7 +174,7 @@ public function testSaveDuplicateDataInsert(): void
                 'album_id' => 1,
                 'title'    => 'Sahabat Sejati',
                 'author'   => 'Erros Chandra',
-            ]
+            ],
         );
     }
 
@@ -185,15 +185,15 @@ public function testSaveDuplicateDataUpdate(): void
                 'album_id' => 1,
                 'title'    => 'Sahabat Sejati',
                 'author'   => 'Erros Chandra',
-            ]
+            ],
         ));
 
         $this->assertTrue($this->repository->save(
             [
                 'album_id' => 1,
                 'title'    => 'Temani Aku',
                 'author'   => 'Erros Chandra',
-            ]
+            ],
         ));
 
         $lastId = Database::connect()->insertID();
@@ -205,7 +205,7 @@ public function testSaveDuplicateDataUpdate(): void
                 'album_id' => 1,
                 'title'    => 'Sahabat Sejati',
                 'author'   => 'Erros Chandra',
-            ]
+            ],
         );
     }
 }

test/unit/Domain/Album/AlbumNotFoundExceptionTest.php

@@ -30,7 +30,7 @@ public function testInstantiateforAlbumDoesnotExistOfId(): void
     {
         $this->assertInstanceOf(
             AlbumNotFoundException::class,
-            AlbumNotFoundException::forAlbumDoesnotExistOfId(1)
+            AlbumNotFoundException::forAlbumDoesnotExistOfId(1),
         );
     }
 }

test/unit/Domain/Track/TrackNotFoundExceptionTest.php

@@ -30,7 +30,7 @@ public function testInstantiateforAlbumTrackDoesnotExistOfId(): void
     {
         $this->assertInstanceOf(
             TrackNotFoundException::class,
-            TrackNotFoundException::forAlbumTrackDoesnotExistOfId(1)
+            TrackNotFoundException::forAlbumTrackDoesnotExistOfId(1),
         );
     }
 }