Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS support for preview thumbnails #2777

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mdkieran
Copy link

Link to related issue (if applicable)

#2589
#2501

Summary of proposed changes

Hello Sam, thank you for taking the time to check out this PR.

Currently, plyr can't fetch preview thumbnails when they're stored on a secure CDN. To solve this, we simply need to set withCredentials to true on the xhr request object in the preview-thumbnails plugin.

The solution I've proposed will solve the use cases in the GitHub issues raised above about this. Jadson from issue #2589 did suggest a more elegant solution. However, as this codebase is using a custom fetch() function, it doesn't make sense to do it that way, perhaps in the future it could be considered.

I've tried my best to follow your coding and language style, and if you have any questions or require any changes please let me know.

@mdkieran mdkieran marked this pull request as ready for review February 18, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants