fix: allow unlisted vimeo video urls when loading using data attributes (#2504) #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampotts
reviewed
Sep 9, 2022
| // In case hash is not explicitly set as attribute we try to parse it from the id attribute | ||
| if (!hash) { | ||
| hash = parseHash(source); | ||
| alert(hash); |
There was a problem hiding this comment.
I guess we need to remove the alert() here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to related issue (if applicable)
#2504
Also see #2322 which fixed the issue, except for the case when data attributes are used.
Also this old ticket #593 can probably be closed with this fix.
Summary of proposed changes
This allows us to use URLs of unlisted Vimeo videos in the data-plyr-embed-id data attribute. Currently, data-plyr-embed-id does work with full vimeo URLs like this
<div id="player" data-plyr-provider="vimeo" data-plyr-embed-id="https://vimeo.com/40648169"></div>but it doesn't work when the URL contains an additional hash (unlisted video):
<div id="player" data-plyr-provider="vimeo" data-plyr-embed-id="https://vimeo.com/729894358/7767dc808d"></div>I found an undocumented data attribute called data-plyr-embed-hash which can be used to set the hash separately. But if we allow setting full URLs using the data-plyr-embed-id attribute, I would expect to be able to pass the URL including the hash to this attribute without having to care about the privacy settings of the video myself.