Fixed Plyr sizing in a better way #2022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kgnfth
reviewed
Nov 17, 2020
| @@ -13,6 +13,7 @@ | |||
| font-variant-numeric: tabular-nums; // Force monosace-esque number widths | |||
| font-weight: $plyr-font-weight-regular; | |||
| line-height: $plyr-line-height; | |||
| max-height: 100% | |||
|
its still the same
|
kgnfth
reviewed
Nov 17, 2020
| @@ -13,6 +13,7 @@ | |||
| font-variant-numeric: tabular-nums; // Force monosace-esque number widths | |||
| font-weight: $plyr-font-weight-regular; | |||
| line-height: $plyr-line-height; | |||
| max-height: 100% | |||
There was a problem hiding this comment.
changing max-height to height will fix this
to this
|
In my case, 3.6.3 version was a bit destructive... Here is a basic explanation: |
|
Yeah I think we might need to add a new option. I'm still working on this, expect to get somewhere by the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to related issue (if applicable)
Should fix the issue in a way that both #1997 and #1651 work.
Summary of proposed changes
Checklist
developas the base branch/distchanges) from the PR