feat: two-person approval for sensitive actions (#248)#269
Open
Abdulrasaq1515 wants to merge 1 commit into
Open
feat: two-person approval for sensitive actions (#248)#269Abdulrasaq1515 wants to merge 1 commit into
Abdulrasaq1515 wants to merge 1 commit into
Conversation
|
@Abdulrasaq1515 is attempting to deploy a commit to the webverse Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
Resolve conflict |
Abdulrasaq1515
force-pushed
the
feat/two-person-approval-248
branch
from
a4ffe88 to
ed8d51b
Compare
Author
|
done fixing |
Sensitive actions (feature, unfeature, delete) now require a second admin to confirm before executing. The admin who initiated the request cannot approve it themselves - enforced at the API level. Changes: - Add approval_requests Firestore collection + SQL migration - POST /api/projects/:id/request-approval - submit a pending request - GET /api/approval-requests - list requests by status - PUT /api/approval-requests/:id/approve - second admin approves + executes - PUT /api/approval-requests/:id/reject - second admin rejects - /api/projects/:id/approve blocks feature/unfeature with 403 requiresApproval - /api/projects/:id/delete blocks deletion with 403 requiresApproval - Admin UI: Feature/Unfeature/Delete buttons replaced with RequestApprovalDialog - Admin UI: new Approvals tab with ApprovalQueue component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #248
Sensitive actions (feature, unfeature, delete) now require a second admin to confirm before executing. The admin who initiated the request cannot approve it themselves - enforced at the API level.
Changes: