Skip to content

Conversation

@JustinMeans
Copy link

The following fixes are proposed to enable the library to compile in release mode.

Thanks for creating this library!

This was the build error given when compiling in release prior to these changes:

/Users/justinmeans/Downloads/websocket-actor-system/Sources/WebSocketActors/Continuation.swift:33:58: error: extra argument in call
        await withUnsafeContinuation(function: function, body)
                                    ~~~~~~~~~~~~~~~~~~~~~^~~~~
/Users/justinmeans/Downloads/websocket-actor-system/Sources/WebSocketActors/Continuation.swift:33:48: error: cannot convert value of type 'String' to expected argument type '(UnsafeContinuation<T, Never>) -> Void'
        await withUnsafeContinuation(function: function, body)
                                               ^
/Users/justinmeans/Downloads/websocket-actor-system/Sources/WebSocketActors/Continuation.swift:39:70: error: extra argument in call
        try await withUnsafeThrowingContinuation(function: function, body)
                                                ~~~~~~~~~~~~~~~~~~~~~^~~~~
/Users/justinmeans/Downloads/websocket-actor-system/Sources/WebSocketActors/Continuation.swift:39:60: error: cannot convert value of type 'String' to expected argument type '(UnsafeContinuation<T, any Error>) -> Void'
        try await withUnsafeThrowingContinuation(function: function, body)

@JulianKahnert
Copy link

@samalone thank you for this awesome project 🙏

I can confirm that the changes from @JustinMeans will fix the issues. Do plan to merge the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants