Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Basic js python example #428

Merged
merged 12 commits into from
Feb 3, 2024
Merged

Add Basic js python example #428

merged 12 commits into from
Feb 3, 2024

Conversation

bm777
Copy link
Collaborator

@bm777 bm777 commented Dec 7, 2023

Description

This PR adds a Python example on top of basic-lang-javascript. We identified the need for this feature in response to some user feedback specifically in #427. It is described and commented on.

Files added:

  1. scripts/runner.sh -> to run python file (The user can also run python directly via the exec child-process)
  2. scripts/main.py -> Python script that the user wants to execute.

Modification

  • added directly the main/ folder into the example folder because of some modification in the basic-js-python/main/background.js file which is different from the _template/js/main/background.js. Just to avoid some mix in the dev.js to manage or orchestrate the creation of the Nextron project via the example command.
Screen.Recording.2023-12-07.at.01.39.08.mov

@bm777 bm777 added the examples Resolve by adding examples label Dec 7, 2023
@bm777
Copy link
Collaborator Author

bm777 commented Jan 13, 2024

This cannot be merged, because it is not configured as you did for js.
@saltyshiomix

@saltyshiomix
Copy link
Owner

@bm777

Sorry for late reply.

It works fine even if production build!

I'll merge it after some fixes :)

@bm777
Copy link
Collaborator Author

bm777 commented Feb 3, 2024

:)

Copy link
Owner

@saltyshiomix saltyshiomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@saltyshiomix saltyshiomix merged commit 11d0fd2 into main Feb 3, 2024
1 check passed
@saltyshiomix saltyshiomix deleted the basic-js-python branch February 3, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Resolve by adding examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants