-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Basic js python example #428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cannot be merged, because it is not configured as you did for js. |
Sorry for late reply. It works fine even if production build! I'll merge it after some fixes :) |
:) |
saltyshiomix
approved these changes
Feb 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM <3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Python example on top of basic-lang-javascript. We identified the need for this feature in response to some user feedback specifically in #427. It is described and commented on.
Files added:
scripts/runner.sh
-> to run python file (The user can also run python directly via the exec child-process)scripts/main.py
-> Python script that the user wants to execute.Modification
basic-js-python/main/background.js
file which is different from the_template/js/main/background.js
. Just to avoid some mix in the dev.js to manage or orchestrate the creation of the Nextron project via theexample
command.Screen.Recording.2023-12-07.at.01.39.08.mov