Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape spaces found while parsing GPO XMLNS tags #67129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willchenmark
Copy link

What does this PR do?

What issues does this PR fix or reference?

Escapes spaces found in XMLNS urls in Windows GPO documents with %20
Closes #66992

Previous Behavior

Spaces would not be escaped, breaking lgpo state application.

New Behavior

Spaces are properly escaped allow lgpo state application to operate correctly.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@willchenmark willchenmark requested a review from a team as a code owner January 6, 2025 21:52
Copy link

welcome bot commented Jan 6, 2025

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@twangboy
Copy link
Contributor

Let me know if you need help writing tests for this. Looks like a simple unit test on the _encode_xmlns_url function would be enough. And a changelog as well.

@twangboy twangboy self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] win_lgpo does not account for spaces in XMLNS URLs
2 participants