[master] change regex for pkg name match #66880
Conversation
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
salt-project-bot-prod-environment
bot
changed the title
What does this PR do?
Change the regex to accept underscore as an acceptable symbol in package name.
What issues does this PR fix or reference?
According to python normalization rules the underscore (
_) is allowed symbol in package name. Note the examples there allow for underscore.Previous Behavior
When trying to install package with underscore in the name
with pip.installed, although the installation is successful, there's a problem with confirming if the package is installed (and always will trigger changes). It doesn't matter if you refer inpip.installedto the package with original name (with underscore) or with "normalized" name (with dash), always you have one of the following:Comment: There was no error installing package 'requests_ntlm' although it does not show when calling 'pip.freeze'.Comment: There was no error installing package 'requests-ntlm' although it does not show when calling 'pip.freeze'.Note, the JSON output is with original name:
{"name": "requests_ntlm", "version": "1.3.0"}