Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Debugging nightly build failure due to updated action/upload-artifact/merge #66876

Open
wants to merge 12 commits into
base: 3006.x
Choose a base branch
from

Conversation

dmurphy18
Copy link
Contributor

@dmurphy18 dmurphy18 commented Sep 6, 2024

What does this PR do?

Debugging nightly build failure due to latest 4.4.0, in order to research nightly build Test Report failures

What issues does this PR fix or reference?

Fixes Nightly build

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@dmurphy18 dmurphy18 self-assigned this Sep 6, 2024
@dmurphy18 dmurphy18 requested a review from a team as a code owner September 6, 2024 16:51
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Testing previous version 4.3.6 instead of latest 4.4.0 for action/upload-artifact/merge [3006.x] Testing previous version 4.3.6 instead of latest 4.4.0 for action/upload-artifact/merge Sep 6, 2024
@dmurphy18 dmurphy18 added test:full Run the full test suite test:pkg Run the package tests test:os:all Run Tests Against ALL OS'es test:coverage labels Sep 6, 2024
twangboy
twangboy previously approved these changes Sep 19, 2024
@@ -2027,8 +2027,10 @@ jobs:
id: get-coverage-reports
uses: actions/download-artifact@v4
with:
name: all-testrun-coverage-artifacts
## name: all-testrun-coverage-artifacts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out name?

@@ -2089,8 +2089,10 @@ jobs:
id: get-coverage-reports
uses: actions/download-artifact@v4
with:
name: all-testrun-coverage-artifacts
## name: all-testrun-coverage-artifacts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:coverage test:full Run the full test suite test:os:all Run Tests Against ALL OS'es test:pkg Run the package tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants