[3006.x] Better handling output of systemctl --version
#66856
+101
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
systemctl --versionsystemctl --version
vzhestkov
force-pushed
the
handle-systemctl--version-output
branch
from
5d905c8
to
576d91f
Compare
vzhestkov
force-pushed
the
handle-systemctl--version-output
branch
from
576d91f
to
d86b44f
Compare
dmurphy18
requested changes
Aug 29, 2024
vzhestkov
force-pushed
the
handle-systemctl--version-output
branch
from
d86b44f
to
5051da6
Compare
salt-project-bot-prod-environment
bot
changed the title
systemctl --versionsystemctl --version
3 tasks
dmurphy18
approved these changes
Sep 5, 2024
twangboy
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In some cases calling
systemctl --versionwithsalt.grains.core._systemdcould return unexpected output what could causeIndexErrorexception preventing minion service from running.What issues does this PR fix or reference?
Tracks https://github.com/SUSE/spacewalk/issues/25122
Previous Behavior
IndexErrorexception on starting minions service caused by unexpected response ofsystemctl --versionNew Behavior
Normal minion start with just error message in the log about unexpected output.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.