[master] Stop using egrep #66832
Open
[master] Stop using egrep #66832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When egrep is used, a nasty warning from grep saying egrep should be replaced by grep -E appears on the executed command. This leads to failure matching returned values from `semanage fcontext`. This fix fixes it.
salt-project-bot-prod-environment
bot
changed the title
|
@Rudd-O This PR requires a changelog entry and tests new or updated if current tests are insufficient to test the code changes, no PR is accepted without the above. You might want these changes to appear on the 3006.x or 3007.x branch for an earlier release, given the master branch will become 3008 some time in the future. |
twangboy
requested changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When egrep is used, a nasty warning from grep saying egrep should be replaced by grep -E appears on the executed command. This leads to failure matching returned values from
semanage fcontext.This fix fixes it.
What issues does this PR fix or reference?
Have not noticed any bugs reported on this.
Previous Behavior
Failure running
selinux.fcontext_policy_present.New Behavior
It works.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.