-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Add onlyifrunning option for Service Beacon #66809
base: master
Are you sure you want to change the base?
[master] Add onlyifrunning option for Service Beacon #66809
Conversation
d55137e
to
fd955f8
Compare
fd955f8
to
38a5731
Compare
I think the name of this should change.
Perhaps something like |
Ah, yes. I was a bit lost in naming the parameter. Maybe filter should be added, as it will filter out only the matched state? Something like |
38a5731
to
f31ebe9
Compare
@Sxderp I have renamed the parameter to |
f31ebe9
to
9cb4544
Compare
With this option it's able to only fire events that match the running state
9cb4544
to
df9cfbc
Compare
With this option it's able to only fire events that match the running state
What does this PR do?
I added this change because I don't want my Salt master being overloaded with events I'm not interested in. In my case I only would receive an event when the service is stopped. Without this change the event bus is, for all connected minions, overloaded with events about the running services which I will ignore. This will filter these events from the beacon directly.
What issues does this PR fix or reference?
Previous Behavior
Without this option it will fire the event without filtering the running state
New Behavior
It allows the user to configure that an event should only be fired when the running state is matched with what's configured per service.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.