[wip] [3006.x] Test fix #66777
Open
[wip] [3006.x] Test fix #66777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy18
reviewed
Aug 5, 2024
| @@ -84,11 +84,10 @@ def test_salt_versions_report_minion(salt_cli, salt_call_cli, salt_minion): | |||
| @pytest.mark.parametrize( | |||
| "binary", ["master", "cloud", "syndic", "minion", "call", "api"] | |||
| ) | |||
| def test_compare_versions(binary, install_salt): | |||
| def test_compare_versions(binary, version, install_salt): | |||
There was a problem hiding this comment.
Wondering why have version passed in, since install_salt has several versions available in it.
Also just grepped and test_compare_versions is not called by anything, so wondering about version getting passed in and used on line 192-191
Presuming version is same as used in test_salt_version, that is, output of test.version, hence an optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
Fixes
Previous Behavior
Remove this section if not relevant
New Behavior
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.