Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CoE] Content libraries #342

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

[CoE] Content libraries #342

wants to merge 21 commits into from

Conversation

jgangel
Copy link
Contributor

@jgangel jgangel commented Jan 12, 2023

This includes modules, state and their corresponding unit tests for content libraries

@jgangel jgangel changed the title Content library only [CoE] Content libraries Jan 12, 2023
dmurphy18
dmurphy18 requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick glance over the files, and noted we need to get the copyright and license statements in there. This probably needs to be done for all files to be compliant with the Open Source Office.

src/saltext/vmware/modules/subscribed_library.py Outdated
@@ -0,0 +1,127 @@
# Copyright 2021 VMware, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021-2023

src/saltext/vmware/states/content_library.py
@@ -0,0 +1,91 @@
# SPDX-License-Identifier: Apache-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing copyright

tests/unit/modules/test_content_library.py
@@ -0,0 +1,116 @@
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright and license

tests/unit/states/test_content_library.py
@@ -0,0 +1,155 @@
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright and license

@jgangel
Content library module
0f370f9
@jgangel
Create subscribed library module based on content library one
528c338
@jgangel
Added posible content lib module unit test
1b87b62
@jgangel
Content library state initial setup
f6540dc
@jgangel
Rename content_library to vsphere_content_library
4cb6c7d
@jgangel
Content library state initial changes
ed11429
@jgangel
Fixed content library transformation
fb03fdb
@jgangel
Fixed content library config transformation
c531fb6
@jgangel
Using content library config directly
477bd88
@jgangel
Content library config state fix
fbb6944
@jgangel
Test content library list
1d8e4d5
@jgangel
Fixed content library transform config
a63329b
@jgangel
Validations on content library state file
9fba205
@jgangel
Content library remediation
71e006f
@jgangel
Fix new library auth key
784a950
@jgangel
Content library fixes for remediation
4952d7d
@jgangel
Fix changes_required for content library state
a04b38b
@jgangel
Content library test detailed list
02ecb05
@jgangel
Content library module full success unit test
6efb5d1
@jgangel
Tests for content library state
eff7f65
@jgangel
Copyright libraries
3f5224c
waynew
waynew suggested changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked the rest of this PR yet, but it does need a changelog 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmurphy18 dmurphy18 dmurphy18 requested changes

@waynew waynew waynew requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgangel @waynew @dmurphy18