Fix up python/salt versions to get tests working again #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the salt and python versions to test against to limit to currently supported versions of salt (3009.9 and 3007.1) and removes old python versions.
Updates requirement for current version of pytest-salt-factories and adds cryptographer as a requirement, otherwise salt-master fixture fail
Updates GH action runners to use ubuntu-24.04 as 20.04 is pretty old and there shouldn't be any issues running on an up to date ubuntu version
Updates GH actions config to use Ubuntu 22.04 as the temporary sshd set up as a fixture by pytest-salt-factories hangs on 24.04. Will need to resolve this eventually, but testing on 22.04 should be fine for the moment.
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up the combinations of salt and python versions so that tests will pass again
That's reduced the combination slightly, but I think it's reasonable to not try and test against really old python versions. This is now testing: