Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): add repo config for Ubuntu-24.04 #171

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

tmclo
Copy link
Contributor

@tmclo tmclo commented Aug 31, 2024

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

#170

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@tmclo tmclo requested a review from hatifnatt as a code owner August 31, 2024 15:17
@hatifnatt
Copy link
Collaborator

Thanks for contribution! I don't want to nitpick but would you mind to update commit message to something more specific like "fix(repo): add repo config for Ubuntu-24.04". Changelog is created from this messages so it would be useful to understand specific changes while reading changelog .

@tmclo tmclo changed the title fix(repo): update repo config for keyring fix(repo): add repo config for Ubuntu-24.04 Nov 6, 2024
@tmclo
Copy link
Contributor Author

tmclo commented Nov 6, 2024

Thanks for contribution! I don't want to nitpick but would you mind to update commit message to something more specific like "fix(repo): add repo config for Ubuntu-24.04". Changelog is created from this messages so it would be useful to understand specific changes while reading changelog .

This has been updated now :)

@hatifnatt hatifnatt merged commit 534742b into saltstack-formulas:master Nov 14, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants