Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): avoid name collisions and conflicting ids #446

Closed

Conversation

noelmcloughlin
Copy link
Member

@noelmcloughlin noelmcloughlin commented Jan 22, 2020

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Avoid salt conflicting IDs

Pillar / config required to test the proposed changes

N/A

Debug log showing how the proposed changes work

Detected conflicting IDs, SLS IDs need to be globally unique.
The conflicting ID is 'salt-minion' and is found in SLS 'base:salt.standalone' and SLS 
    'base:salt.minion'

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@noelmcloughlin
Copy link
Member Author

I fixed CI versions.

@noelmcloughlin noelmcloughlin requested a review from myii January 22, 2020 12:45
@noelmcloughlin
Copy link
Member Author

CI is passing now.

@myii
Copy link
Member

myii commented Jan 24, 2020

Let's look at this after finalising #448 and getting that merged.

@myii
Copy link
Member

myii commented Jan 26, 2020

Is this covered by #421 now?

@noelmcloughlin
Copy link
Member Author

Ah okay, It was adopted there independently of this. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants