forked from 0xf10e/iscsi-formula
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(semantic-release): complete for this formula #30
Merged
myii
merged 12 commits into
saltstack-formulas:master
from
myii:chore/standardise-structure
Oct 12, 2019
Merged
feat(semantic-release): complete for this formula #30
myii
merged 12 commits into
saltstack-formulas:master
from
myii:chore/standardise-structure
Oct 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Semi-automated using myii/ssf-formula#62
```bash Examining iscsi/initiator/clean.sls of type state [201] Trailing whitespace iscsi/initiator/clean.sls:9 - .package.clean ```
```bash Examining iscsi/initiator/config/files/default/iscsi.tmpl of type state [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/initiator/config/files/default/iscsi.tmpl:17 {{shift}}{{ key }} { # nickname [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/initiator/config/files/default/iscsi.tmpl:21 {{shift}}{{ key }} = {{"'" if value is not string else ''}}{{ value }}{{"'" if value is not string else ''}} ```
```bash Examining iscsi/initiator/config/files/default/open-iscsi.tmpl of type state [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/initiator/config/files/default/open-iscsi.tmpl:16 {{shift}}{{ key }} = {{ value ~ '\n' if value is string else '"' ~ value ~ '"\n' }} ```
```bash Examining iscsi/isns/clean.sls of type state [201] Trailing whitespace iscsi/isns/clean.sls:8 - .package.clean ```
```bash Examining iscsi/isns/config/files/default/isns.tmpl of type state [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/isns/config/files/default/isns.tmpl:16 {{shift}}{{ key }} = {{ value }} ```
```bash Examining iscsi/target/clean.sls of type state [201] Trailing whitespace iscsi/target/clean.sls:9 - .package.clean ```
```bash Examining iscsi/target/config/files/default/ctld.tmpl of type state [201] Trailing whitespace iscsi/target/config/files/default/ctld.tmpl:17 {{shift}}{{ key }} { [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/target/config/files/default/ctld.tmpl:17 {{shift}}{{ key }} { [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/target/config/files/default/ctld.tmpl:19 {{shift}}} [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/target/config/files/default/ctld.tmpl:21 {{shift}}{{ key }} {{ value }} ```
```bash Examining iscsi/target/config/files/default/ietd.tmpl of type state [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/target/config/files/default/ietd.tmpl:17 {{shift}}{{ key }} [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/target/config/files/default/ietd.tmpl:20 {{shift}}{{ key }} {{ "'" if value is not string else ''}}{{ value }}{{"'" if value is not string else ''}} ```
```bash Examining iscsi/target/config/files/default/lio.tmpl of type state [209] Jinja comment should have spaces before and after: {# comment #} iscsi/target/config/files/default/lio.tmpl:1 {#######################################################} [201] Trailing whitespace iscsi/target/config/files/default/lio.tmpl:3 {# salt://iscsi/target/config/files/default/lio.tmpl #} [201] Trailing whitespace iscsi/target/config/files/default/lio.tmpl:4 {# Your changes may get overwritten. #} [209] Jinja comment should have spaces before and after: {# comment #} iscsi/target/config/files/default/lio.tmpl:5 {#######################################################} [201] Trailing whitespace iscsi/target/config/files/default/lio.tmpl:7 {% set arrays = ('fabric_modules', 'storage_objects', 'alua_tpgs', 'targets', 'node_acls', 'luns', 'mapped_luns', 'portals')%} [202] Jinja statement should have spaces before and after: {% statement %} iscsi/target/config/files/default/lio.tmpl:7 {% set arrays = ('fabric_modules', 'storage_objects', 'alua_tpgs', 'targets', 'node_acls', 'luns', 'mapped_luns', 'portals')%} [201] Trailing whitespace iscsi/target/config/files/default/lio.tmpl:32 {{ '\n' ~ shift ~ '}' if last and parent|lower in ('tpgs',) else '' -}} ```
```bash Examining iscsi/target/config/files/default/tgtd.tmpl of type state [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/target/config/files/default/tgtd.tmpl:17 {{shift}}{{ '<' ~ key ~ '>' }} [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/target/config/files/default/tgtd.tmpl:19 {{shift}}{{ '</' ~ key.split(" ")[0] ~ '>' }} [206] Jinja variables should have spaces before and after: {{ var_name }} iscsi/target/config/files/default/tgtd.tmpl:22 {{shift}}{{ key }} {{ value }} ```
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iscsi-formula
myii/ssf-formula#62@noelmcloughlin This PR brings the implementation into line with the latest structure across
semantic-release
formulas. In includes:salt-lint
&rubocop
tolint
job template-formula#175.salt-lint
andrubocop
).One thing I noticed that I didn't get time to resolve is the missing
tofs
block inpillar.example
. Something like:The
source_files
would need to be updated for all uses offiles_switch
throughout this formula. Since you're the most familiar with that, I'll leave that in your capable hands.