feat(config) remove interfering users.conf

[alxwr]

PR progress checklist (to be filled in by reviewers)

• Changes to documentation are appropriate (or tick if not required)
• Changes to tests are appropriate (or tick if not required)
• Reviews completed

---

What type of PR is this?

Primary type

• [build] Changes related to the build system
• [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
• [ci] Changes to the continuous integration configuration
• [feat] A new feature
• [fix] A bug fix
• [perf] A code change that improves performance
• [refactor] A code change that neither fixes a bug nor adds a feature
• [revert] A change used to revert a previous commit
• [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

• [docs] Documentation changes
• [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

None.

Describe the changes you're proposing

Under FreeBSD 12, the package for Icinga 2.12.3 users.conf contains a user group (icingaadmins) which interferes with commonly used config. Removing this unmanaged file resolves this conflict.

Pillar / config required to test the proposed changes

None.

Debug log showing how the proposed changes work

┌─[salt-master@salt]─[~]
└─╼ % salt --state-output=changes --state-verbose=False 'minion' state.apply icinga2
minion:
----------
ID: /usr/local/etc/icinga2/conf.d/users.conf
Function: file.absent
Result: True
Comment: Removed file /usr/local/etc/icinga2/conf.d/users.conf
Started: 15:43:53.571146
Duration: 0.89 ms
Changes:
----------
removed:
/usr/local/etc/icinga2/conf.d/users.conf
----------
ID: icinga2_service_restart
Function: service.running
Name: icinga2
Result: True
Comment: Service icinga2 is already enabled, and is running
Started: 15:43:53.603166
Duration: 1413.839 ms
Changes:
----------
icinga2:
True

Summary for minion
--------------
Succeeded: 183 (changed=2)
Failed:      0
--------------
Total states run:     183
Total run time:     2.092 s

Documentation checklist

• Updated the README (e.g. Available states).
• Updated pillar.example.

Testing checklist

• Included in Kitchen (i.e. under state_top).
• Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• Updated the relevant test pillar.

Additional context

[baby-gnu]

The inspec is not run by the pipeline because no platform is enable in .gitlab-ci.yml.

[baby-gnu]

Thanks.

[myii]

I've been working on reintroducing the CI for this formula, using GitHub Actions (thanks to @dafyddj). It's working:

• https://github.com/myii/icinga2-formula/actions/runs/625110522

However, when I push this commit on top, it fails during the kitchen converge stage:

• https://github.com/myii/icinga2-formula/actions/runs/625100586

@alxwr Would you care to have a look at the logs there, to figure out what's going on? By the time you do that, I should have GitHub Actions running here, so you'll be able to rebase and get the CI running for this PR.

[myii]

@alxwr Ran this locally to see what's preventing the service from running and this is what I've found (using journalctl -xe):

icinga2[6551]: [] critical/config: Error: Validation failed for object 'alice' of type 'User'; Attribute 'groups': Object 
icinga2[6551]: Location: in /etc/icinga2/conf.d/users/alice.conf: 4:3-4:29
icinga2[6551]: /etc/icinga2/conf.d/users/alice.conf(2): object User "alice" {
icinga2[6551]: /etc/icinga2/conf.d/users/alice.conf(3):   email = "[email protected]"
icinga2[6551]: /etc/icinga2/conf.d/users/alice.conf(4):   groups = [ "icingaadmins" ]
icinga2[6551]:                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
icinga2[6551]: /etc/icinga2/conf.d/users/alice.conf(5):   vars.jabber = "[email protected]"
icinga2[6551]: /etc/icinga2/conf.d/users/alice.conf(6): }
icinga2[6551]: [] critical/config: 1 error
icinga2[6551]: [] critical/cli: Config validation failed. Re-run with 'icinga2 daemon -C' after fixing the config.