-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template-formula): adapt template-formula format #10
feat(template-formula): adapt template-formula format #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may not get a chance to check the rest of the changes but everything regarding semantic-release
is looking good. Just a few notes to consider, though:
- The one inline comment.
- The tests need to be fixed, otherwise
semantic-release
won't run at all!
thanks @myii. this PR is aligned to saltstack-formulas/sysstat-formula#12 so should be good for semantic release once I fix your comments above. This formula is only used by me and I'm happy its working good once travis is passing. |
1ec0df6
to
91718c9
Compare
Co-Authored-By: Imran Iqbal <[email protected]>
728ce54
to
6786612
Compare
…a-formula into template-formula
4d5c65b
to
f174a52
Compare
f174a52
to
3035ab7
Compare
Hi @myii travis CI is passing now (fingers crossed on suse-15 on next run - long story). What else is needed for a semantic release? Do you need me to squash all the commits for example? |
Resolves #11 |
25dd74d
to
4eb812c
Compare
4eb812c
to
b4bb933
Compare
@noelmcloughlin From a |
The commits are fine as is, as long as it does not make enabling semantic release more difficult. |
@noelmcloughlin and @myii shall I merge this one without squashing? |
Hopefully Suse Travis CI is fixed too. |
@aboe76 All clear from my end; as soon as @noelmcloughlin has finished work here, it's ready to go. From the message above, it appears that's the case. Good work! |
yes. thanks guys |
Merged, thanks for all of the work @noelmcloughlin and to @aboe76 for the prompt! |
@noelmcloughlin The |
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR migrates to
template-formula
format.This PR also includes some fixes for
deepsea.source
state (see also upstream)