Handle JSONException while reading Renovate configuration file #1130
Conversation
Catch json exception
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
============================================
+ Coverage 85.91% 85.93% +0.02%
Complexity 390 390
============================================
Files 27 27
Lines 1292 1294 +2
Branches 167 167
============================================
+ Hits 1110 1112 +2
Misses 146 146
Partials 36 36
|
| } catch (JSONException e) { | ||
| log.debug("Exception while trying to read the renovate configuration file. Exception: {}", e.getMessage()); |
There was a problem hiding this comment.
Its helpful to state what the expected return value is in the error message for this situation. For example we can add the phase returning false to the message.
There was a problem hiding this comment.
@cjneasbi Updated
Add expected return value to error message
| @@ -64,9 +65,11 @@ protected boolean isRenovateEnabled(List<String> filePaths, GitHubContentToProce | |||
| //If the file has the key 'enabled' set to false, it indicates that while the repo has been onboarded to renovate, it has been disabled for some reason | |||
| return readJsonFromContent(fork.getParent().getFileContent(filePath)).optBoolean("enabled", true); | |||
| } catch (FileNotFoundException e) { | |||
| log.debug("The file with name {} not found in the repository. Exception: {}", filePath, e.getMessage()); | |||
| log.debug("The file with name {} not found in the repository.Returning false. Exception: {}", filePath, e.getMessage()); | |||
There was a problem hiding this comment.
FileNotFoundException error should be in the debug log because we are expecting this for most of the repos. But do we want to do that for IO and JSON exceptions as well? We should log it in warn mode if they are expected to be raised in corner cases
There was a problem hiding this comment.
@jeetchoudhary Updated
Changing log level to warn
No description provided.