Multi AOP #5426

gymad · 2018-03-07T12:56:15Z

Description

ability to join multiple joomla site to suitecrm

Motivation and Context

How To Test This

join multiple joomla site to crm, try each functionality in cases module with multiple users...
test for backward compatibility, upgrade an older version of suitecrm and add more joomla sites

at the admin panel, check is multiple validation type correct for us and do we need the validation here?
test somehow the marking as undeleted was success?
at updating portal, check which joomla url need for us to send because since it's multiple it does not make sense

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

My code follows the code style of this project found here.
My change requires a change to the documentation.
I have read the How to Contribute guidelines.

pick commits from old repo: handle some user error e17ffe0d resolve some console error on SuiteP login f5ed4899 09 May, 2017 8 commits Merge branch 'staging' into 'develop-430/432-multi_aop' ... 89c9fe34 JAccount validation af3bd372 error handling at JAccount save a58cd219 handle array msgs d91fac51 dbg refact b0b02a9c typo func name fix 694bbe3d typo fix db857ff9 add debug info for testing on dev bad8fc93 08 May, 2017 5 commits remove dbg and remove a php notice c391e062 more informative begub and errorhandling for dev srv 46d5b4b9 signed exeption if no trace info bc110409 handle some error and infos 098310ec typo fix 4f6b489d 11 Apr, 2017 4 commits upgrade portal url in config 7f3b6eca creator portal url 77cf5f30 Merge branch 'develop' into develop-430/432-multi_aop a0683125 gitignore autogenerated style.css.map 9435c1fd 10 Apr, 2017 1 commit use only one related jaccount per contact/portal 7e3e7f79 07 Apr, 2017 12 commits a style fix 8ffff73d fix submenu funcs 1a4284e6 scss color link f2c5f81e a licens header added 8621a658 fix admin aop urls inputs 73896b0c delete non used files 02feca9e a typo 3ffc7960 aop xml check 5d5c736e backward compatible cf9c34e4 keep synch contact data for portal d3d5ece0 refact 32bac9c7 create/enable/disable only at these portal url(s) where it's possible 18d72beb 05 Apr, 2017 1 commit add multiple portal (code refact needed) 55798ad3 04 Apr, 2017 1 commit add dropdowns 4b283ceb 03 Apr, 2017 1 commit multiple portal url in AOP f9babe7a

pick up commits from old repo: class in separated files fabf9c8b check for email sent and fix a php notice edb91aeb fix email sending to created aop user e7568f04 retrieve rest requested jaccount 3f804dcf fix portal user creation email 7ae04322 15 May, 2017 2 commits handle portal version error 01b891ea refacts and fixes

…ter runing

daniel-samson · 2018-03-07T16:28:52Z

.travis.yml

@@ -25,7 +25,7 @@ before_script:
 script:
  - \[ -f "config_si.php" \] || cp tests/travis_config_si.php config_si.php
  - php tests/testinstall.php
-  - ./vendor/bin/codecept run -f unit --steps -vvv --debug
+  - ./vendor/bin/codecept run unit --steps -vvv


we need to ensure that codeception returns 1 as soon as it finds an issue in the tests. Please revert the option -f.

daniel-samson · 2018-03-07T16:32:49Z

modules/AOP_Case_Updates/Case_Updates.php

@@ -355,10 +363,10 @@ function quick_edit_case_updates($case)
    $html = <<< EOD
    <form id='case_updates' enctype="multipart/form-data">

-    <div><label for="update_text">{$mod_strings['LBL_UPDATE_TEXT']}</label></div>
+    <div><label for="update_text"></label></div>


Why are we removing the translation in the label? Should we remove the translation here? What effect does removing this label have?

daniel-samson · 2018-03-07T16:36:50Z

modules/AOP_Case_Updates/util.php

@@ -130,25 +136,39 @@ function aop_parse_template($string, $bean_arr)

    foreach ($bean_arr as $bean_name => $bean_id) {

-        $focus = BeanFactory::getBean($bean_name, $bean_id);
+        if($focus = BeanFactory::getBean($bean_name, $bean_id)) {


This creates a PHP Notice. Consider moving the $focus to the line above, and then checking if (empty($focus)).

No, it doesn't, this line set the $focus.

daniel-samson · 2018-03-07T16:41:18Z

modules/AOP_Case_Updates/util.php

+ * @return boolean
+ */
+function url_exists($url) {
+    if (!$fp = curl_init($url)) return false;


Our coding standards states we must use {} for if statements. However perhaps it would be better to do something like this:

return (curl_init($url) !== false);

curl_init returns false when an error occurs

daniel-samson · 2018-03-07T16:47:26Z

modules/Administration/AOPAdmin.tpl

@@ -72,11 +72,12 @@
            $('#enable_aop').change();
            $('#enable_portal').change(function (){
                if($('#enable_portal').is(":checked") && $('#enable_aop').is(":checked")){
-                    addToValidate('ConfigureSettings','joomla_url','text',true,"{/literal}{$MOD.LBL_AOP_JOOMLA_URL}{literal}");
-                    $('#joomla_url_row').show();
+                    // TODO: check is multiple validation type correct for us and do we need the validation here?


Please remove TODO.

daniel-samson · 2018-03-07T17:17:12Z

modules/JAccount/vardefs.php

+                'len' => 36,
+                'size' => '20',
+            ),
+        'email1' =>


please define the email1 in the JAccount class.

daniel-samson · 2018-03-07T17:17:32Z

modules/JAccount/vardefs.php

+                'type' => 'varchar',
+                'len' => '255',
+                'importable' => 'false',
+                'studio' => 'true',


please define the joomla_account_id in the JAccount class.

daniel-samson · 2018-03-07T17:17:51Z

modules/JAccount/vardefs.php

+                'importable' => 'false',
+                'studio' => 'true',
+            ),
+        'portal_account_disabled' =>


please define the portal_account_disabled in the JAccount class

daniel-samson · 2018-03-07T17:18:03Z

modules/JAccount/vardefs.php

+                'importable' => 'false',
+                'studio' => 'false',
+            ),
+        'joomla_account_access' =>


please define the joomla_account_access in the JAccount class

daniel-samson · 2018-03-07T17:18:15Z

modules/JAccount/vardefs.php

+                'importable' => 'false',
+                'studio' => 'false',
+            ),
+        'portal_user_type' =>


please define the joomla_account_access in the JAccount class

horus68 · 2018-03-07T17:45:34Z

Do @salesagility also plan to make some upgrade in the joomla plugin?
Its Github its almost dead since 2016, no PR merged (even the simplest ones), no issues solved.
See: https://github.com/salesagility/SuiteCRM-Portal-Joomla

Note: the ZIP download its also not available from your site!

daniel-samson · 2018-03-08T09:36:21Z

@horus68 We will be updating the AOP plugin for joomla. So that it can support this feature and the new OAuth 2 server.

horus68 · 2018-03-08T13:11:11Z

modules/JAccount/language/en_us.lang.php

+  'LNK_NEW_RECORD' => 'Create JAccount',
+  'LNK_LIST' => 'View JAccount',
+  'LNK_IMPORT_JACCOUNT' => 'Import JAccount',
+  'LBL_SEARCH_FORM_TITLE' => ' JAccount',


Is it intended to start with a space in ' JAccount',?

samus-aran · 2018-03-08T13:54:38Z

@gymad Perhaps link this up with the appropriate Joomla plugin PR for people to test thoroughly.

Dillon-Brown · 2018-03-08T15:07:05Z

@horus68 The zip can be found here: https://suitecrm.com/resources/suitecrm-joomla-portal-plug-in/

horus68 · 2018-03-08T19:29:58Z

@Dillon-Brown great to have this back again, even if just 2.0.1 version (nov 2016).
Hope the developments are made considering the 3beta branch, the 3.0.0 beta version (XML dated from October 2015), as it includes the feature for Advanced Open Knowledge Base

gymad · 2018-03-09T10:15:49Z

@samus-aran the link to the Joomla portal PR: salesagility/SuiteCRM-Portal-Joomla#25

Mac-Rae · 2019-08-05T14:14:08Z

Please resolve the conflicts on this pull request bringing it up to date.

horus68 · 2019-10-31T14:01:46Z

@gymad any update to solve conflicts here?

chris001 · 2020-05-14T13:44:28Z

No plan to resolve conflicts, update this PR or merge this multi joomla portal feature?

gymad added 8 commits March 7, 2018 10:31

code cleanup

d531654

fix php warning

79c3c1b

fix php notices

89706c3

fix some php notices and warnings

5e00fad

update phpdoc

03e3f7b

update licence and cleanup code

e9827ae

gymad changed the title ~~Develop multi aop~~ WIP: Develop multi aop Mar 7, 2018

fix a test

f13fc84

gymad force-pushed the develop_multi_aop branch from 234ba9d to f13fc84 Compare March 7, 2018 14:28

gymad added 5 commits March 7, 2018 14:34

fixing test

f4ec347

fix test

3772549

fix test

4b2a202

fix test

3da10b6

travis do not stop at first failing test and do not use debug for fas…

7492e52

…ter runing

gymad changed the title ~~WIP: Develop multi aop~~ Develop multi aop Mar 7, 2018

gymad changed the title ~~Develop multi aop~~ Multi AOP Mar 7, 2018

daniel-samson suggested changes Mar 7, 2018

View reviewed changes

gymad added 9 commits March 8, 2018 09:59

add -f param to codecept

f70da6e

revert label texts

e3328c7

a CS fix

493ad12

removing a todo

07348b5

update a phpdoc

4f75c49

set a default message with a default status code

579c401

set a default message with a default status code

386f56f

remove a todo

5ef7ba0

remove a todo

bf30f77

gymad added 4 commits March 8, 2018 10:49

remove todo

5ace0c4

define a default message and error code.

602d858

default message and error code.

9249680

add some data tag to class JAccount

bec47dd

daniel-samson approved these changes Mar 8, 2018

View reviewed changes

horus68 reviewed Mar 8, 2018

View reviewed changes

gymad added 2 commits March 9, 2018 10:16

lang text fixed

55c6509

Merge branch 'develop' into develop_multi_aop

a279f2e

gymad closed this Apr 26, 2018

gymad reopened this Apr 26, 2018

Mac-Rae added the Status: Requires Updates Issues & PRs which requires input or update from the author label Aug 5, 2019

mattlorimer closed this May 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi AOP #5426

Multi AOP #5426

gymad commented Mar 7, 2018 •

edited

Loading

daniel-samson Mar 7, 2018

daniel-samson Mar 7, 2018

daniel-samson Mar 7, 2018

gymad Mar 8, 2018

daniel-samson Mar 7, 2018

daniel-samson Mar 7, 2018

daniel-samson Mar 7, 2018

daniel-samson Mar 7, 2018

daniel-samson Mar 7, 2018

daniel-samson Mar 7, 2018

daniel-samson Mar 7, 2018

horus68 commented Mar 7, 2018 •

edited

Loading

daniel-samson commented Mar 8, 2018

horus68 Mar 8, 2018 •

edited

Loading

samus-aran commented Mar 8, 2018

Dillon-Brown commented Mar 8, 2018

horus68 commented Mar 8, 2018

gymad commented Mar 9, 2018

Mac-Rae commented Aug 5, 2019

horus68 commented Oct 31, 2019

chris001 commented May 14, 2020

Multi AOP #5426

Multi AOP #5426

Conversation

gymad commented Mar 7, 2018 • edited Loading

Description

Motivation and Context

How To Test This

Types of changes

Final checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

horus68 commented Mar 7, 2018 • edited Loading

daniel-samson commented Mar 8, 2018

horus68 Mar 8, 2018 • edited Loading

Choose a reason for hiding this comment

samus-aran commented Mar 8, 2018

Dillon-Brown commented Mar 8, 2018

horus68 commented Mar 8, 2018

gymad commented Mar 9, 2018

Mac-Rae commented Aug 5, 2019

horus68 commented Oct 31, 2019

chris001 commented May 14, 2020

gymad commented Mar 7, 2018 •

edited

Loading

horus68 commented Mar 7, 2018 •

edited

Loading

horus68 Mar 8, 2018 •

edited

Loading