Feat/examples sandbox tests#237
Merged
salazarsebas merged 8 commits intoJul 3, 2026
Merged
Conversation
|
@KevinMB0220 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…as#225 - Add .gitignore to all 39 examples (target/, *.wasm; keep Cargo.lock) - Remove Cargo.lock exclusion from root and example .gitignore files - Fix inaccurate Cargo.toml descriptions and trading_card_game package name - Sanitize READMEs: remove contract IDs, tx hashes, promotional emoji - Restore tic_tac_toe README markdown (no HTML entities) - Add scripts/verify_hygiene.sh and update enforcement tooling
…rds compliance - Replace absolute file:// sandbox_tests links with relative paths in snake and battleship READMEs - Add invalid-input rejection tests for ZK canonical examples per EXAMPLE_STANDARD §5 (hidden_hand, fog_explorer, dice_duel, blind_auction) - Assert hidden_hand verify_deal return value against circuit spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Align Canonical Examples with Quality Standards & Implement GameHarness Sandbox Tests
Description
This PR brings the canonical 1.1.0 reference examples to full compliance with
EXAMPLE_STANDARD.md(Issue #217) and integratesGameHarnessandScenario-based multi-turn integration testing across key onboarding examples (Issue #222).Key Changes
Dependency Modernization:
cougr-core = "1.1.0"in target examples dependencies.cougr-core = { version = "1.1.0", features = ["testutils"] }indev-dependencies.soroban-sdk = "25.1.0".GameHarness Scenario Tests:
sandbox_tests.rsmodules containing multi-step scenario tests (at least 3 actions with intermediate state assertions) forspawn_and_move,tic_tac_toe,snake, andbattleship.Cloneon game contracts (TicTacToeContract,SnakeContract,BattleshipContract) to support testing registry constraints in the harness.Standard-Compliant Documentation:
README.mdfiles fortic_tac_toe,session_arena,hidden_hand,fog_explorer,dice_duel, andblind_auctioncovering all required sections of §4 (API tables, storage model, gameplay flow, architecture).spawn_and_move,snake, andbattleshipto recommendGameHarnessandScenarioas the primary testing tools.examples/README.md.CI Pipelines:
spawn_and_moveandsession_arenausing the reusable workflow runner..github/workflows/circuit_examples.ymlZK check matrices to executestellar contract build(WASM target build checks) in addition to tests.Verification
Verified all targets locally with:
cargo test-> Passed successfully.stellar contract build-> WASM compilation succeeded.Related Issues