Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by metadata #377

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

stasinos
Copy link

Adds the feature to use XMP tags to select the images that will be included in the gallery.

@Glandos
Copy link
Contributor

Glandos commented Oct 17, 2019

If I remember correctly, pyexiv2 was deliberately not used, in the name of ease of installation.
I might be wrong, @saimn will confirm this or not.

I know that it is a powerful library, and that metadata is not well supported with Pillow.

@stasinos
Copy link
Author

I didn't have to do anything more than pip install, but maybe I was just lucky with glibc versions and such, travis here doesn't look happy. If that is a deciding factor, I can try to make this conditional so that pyexiv2-less installations are just as easy as they are now, but ignore the tag filters.

@saimn
Copy link
Owner

saimn commented Oct 26, 2019

Until recently my knowledge of it was that it was not pip installable, and there was a fork for python 3 support. But maybe things have changed, which can be great. I will try to look more in detail soon.

@saimn
Copy link
Owner

saimn commented Oct 26, 2019

And even if the installation is easier, I think that this feature would fit well in a plugin.

@saimn
Copy link
Owner

saimn commented Oct 26, 2019

Hmm it's a bit confusing:

GExiv2 is an official Gnome project and
also part of Debian, so more likely to
offer a hussle-free installation experience.
@stasinos
Copy link
Author

I wasn't aware of GExiv2, and it looks more likely to offer a hussle-free installation path. The latest commit switches to using that instead.

Not sure about how your plugins work, though. Any pointers?

@saimn
Copy link
Owner

saimn commented Oct 27, 2019

Gexiv2 may be easier to install on Linux, but probably not on MacOS/Windows. There is no package on PyPI.

If I look at PyPI (https://pypi.org/search/?q=exiv2&o=), there is py3exiv2 which is the py3 fork on the old pyexiv2, but it does not provide wheels so you need to install libexiv2-dev and libboost-python-dev and compile. And there is the "new pyexiv2", which provides a universal wheel which is weird for a package containing C code, and it seems that .dll and .so are committed directly in the repository ..

So it's a mess and I do not want this in the core package ;), but if you manage to write a plugin that can work with one or some of these packages then it's fine :)

About plugins: http://sigal.saimon.org/en/latest/plugins.html
You may need a new entry point (signal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants