feat: add remove doctor command - #53
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe pull request introduces a doctor deletion feature by adding a DELETE API endpoint, MediatR command handler, and supporting infrastructure. This includes a new Result type for consistent error handling, Identity service extensions for user disabling, domain model updates with navigation properties, and database migrations to reflect the schema changes. Changes
Sequence DiagramsequenceDiagram
participant Client
participant DoctorsController
participant Mediator
participant DeleteDoctorCommandHandler
participant BookingDbContext
participant IdentityService
participant Database
Client->>DoctorsController: DELETE /api/doctors/{id}
DoctorsController->>Mediator: Send(DeleteDoctorCommand)
Mediator->>DeleteDoctorCommandHandler: Handle(command)
DeleteDoctorCommandHandler->>BookingDbContext: Load Doctor with Appointments
BookingDbContext->>Database: Query Doctor & Appointments
Database-->>BookingDbContext: Doctor entity
BookingDbContext-->>DeleteDoctorCommandHandler: Doctor data
alt Doctor not found
DeleteDoctorCommandHandler-->>Mediator: NotFoundException
else Active future appointments exist
DeleteDoctorCommandHandler-->>Mediator: Exception
else Clear to proceed
DeleteDoctorCommandHandler->>IdentityService: DisableUserAsync(userId)
IdentityService->>Database: Set lockout + Update security stamp
Database-->>IdentityService: Success/Failure
IdentityService-->>DeleteDoctorCommandHandler: Result
alt User disable failed
DeleteDoctorCommandHandler-->>Mediator: Exception with errors
else User disabled successfully
DeleteDoctorCommandHandler->>BookingDbContext: Deactivate doctor + SaveChangesAsync()
BookingDbContext->>Database: Update Doctor.IsActive = false
Database-->>BookingDbContext: Confirmation
BookingDbContext-->>DeleteDoctorCommandHandler: Complete
DeleteDoctorCommandHandler-->>Mediator: Success
end
end
Mediator-->>DoctorsController: Result
DoctorsController-->>Client: 204 No Content / 404 / 400
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Contributor
|
Note Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
Contributor
|
No files have been changed in this PR. Unable to generate unit tests. |
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Chores