polyfills: bundle our own fetch polyfill #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's vendored and slightly adapted whatwg-fetch to start with.
|
Alright, here is the plan. This is not fully spec compliant yet, but it is better tailored for our needs since it's easier to modify. I think the next step would be to create a generic HTTP client which is not XHR or fetch and use it from both directly. This would detach the fetch implementation from XHR and allow us to add the missing stream features. In addition it should simplify the XHR implementation by moving big parts of it to JS. Last, if / when the HTTP library is replaced only one thing needs to be replaced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's vendored and slightly adapted whatwg-fetch to start with.