Document that shortest_vector() returns exact SVP solutions #41266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add detailed notes on shortest_vector method's algorithms and behavior. Clarify that both 'pari' and 'fplll' algorithms compute exact solutions by default, unlike approximate_closest_vector(). Addresses issue sagemath#40355 where the documentation didn't specify whether the method returns exact or approximate solutions.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #40355
This PR clarifies the documentation for
IntegerLattice.shortest_vector()to explicitly state that it returns exact solutions to the Shortest Vector Problem (SVP) by default, addressing confusion about whether the method provides exact or approximate results.Changes Made
.. NOTE::section explaining that both'pari'and'fplll'algorithms compute exact SVP solutions by default'pari'uses PARI'sqfminim()function for exact computation'fplll'uses fpylll's enumeration-based SVP solver by default'fplll'behavior can be modified via*argsand**kwdsparametersapproximate_closest_vector()method to highlight the exactness vs speed trade-offTesting
This is a documentation-only change with no modifications to code logic. All existing doctests remain unchanged and should continue to pass.
📝 Checklist
⌛ Dependencies
None