Skip to content

add sig_on and sig_off to avoid segfault #41264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cxzhong wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

add sig_on and sig_off to avoid segfault #41264

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
97e7244
Add a bound check and Avoid segfault
cxzhong Dec 5, 2025
2238fb9
Refactor get/set methods for direct indexing
cxzhong Dec 5, 2025
26d9da9
delete outdated tests for old methods
cxzhong Dec 5, 2025
2873f38
Fix formatting of example code in free_module_element.pyx
cxzhong Dec 5, 2025
3db8de1
Replace index access with get method in examples
cxzhong Dec 5, 2025
9b5f46d
Enhance tests for vector operations
cxzhong Dec 5, 2025
16578f9
Just use sig_on and sig_off
cxzhong Dec 6, 2025
e4b1afb
Import cysignals for signal handling
cxzhong Dec 6, 2025
55e08dd
Merge branch 'sagemath:develop' into patch-6
cxzhong Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/sage/modules/free_module_element.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ This is a test from :issue:`20211`::
cimport cython
from cpython.slice cimport PySlice_GetIndicesEx

from cysignals.signals cimport sig_on, sig_off

from sage.categories.rings import Rings
from sage.misc.superseded import deprecated_function_alias
from sage.structure.sequence import Sequence
Expand Down Expand Up @@ -1928,7 +1930,10 @@ cdef class FreeModuleElement(Vector): # abstract base class
sage: vector(SR, [1/2,2/5,0]).get(0) # needs sage.symbolic
1/2
"""
return self.get_unsafe(i)
sig_on()
res = self.get_unsafe(i)
sig_off()
return res

def __setitem__(self, i, value):
"""
Expand Down Expand Up @@ -1994,7 +1999,9 @@ cdef class FreeModuleElement(Vector): # abstract base class
(1/2, 2/5, pi)
"""
assert value.parent() is self.coordinate_ring()
sig_on()
self.set_unsafe(i, value)
sig_off()

def __invert__(self):
"""
Expand Down
Loading