-
-
Notifications
You must be signed in to change notification settings - Fork 696
Update sage -b to use ninja and deprecate sage -br #41174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Why would one need to detect the presence of meson files? They are where they should be, it's totally not needed. |
dimpase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and there is no need to invoke meson to mimic what sage -b used to do.
Just invoke ninja
|
we definitely don't care for old make-only compatibility |
|
Instead of invoking the full meson build if no ninja files are found, just error out with the message to run Old habits die hard, we really don't want to encourage people running full builds using obscure non-standard options. This PR should also modify docs accordingly. |
dimpase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's possible to detect that this is a non-editable install, error out with an appropriate message.
|
build_sage() now checks for build/build.ninja and errors out if it's not there I also updated the docs in startup.rst to match the new logic (If there are any other docs files that need changes then let me know). this is what you had in mind right? |
This PR updates the
src/bin/sagescript to correctly handle thesage -bandsage-brflags for modern Meson-based builds.The
build_sage()function is modified to:build/build.ninjaand other standard Meson build directories.ninja: If a Meson build is found, it correctly runsninja -C buildto build the project.( cd "$SAGE_ROOT" && make sagelib-no-deps )command. This ensures it still works for the current hybrid (make+meson) build system and oldermake-only builds.Additionally, the
sage -brflag is now marked as deprecated. It will print a warning message tostderrexplaining that in an editable install, just running./sageis a replacement. It still performs the build and runs Sage as it did before.Fixes #41161.
📝 Checklist
⌛ Dependencies
None.