Basic functionalities for weighted projective {curves, points, spaces} #41170
+914
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 8c4f225; changes) is ready! 🎉 |
vincentmacri
suggested changes
Nov 14, 2025
Member
vincentmacri
left a comment
vincentmacri
left a comment
There was a problem hiding this comment.
Looks good overall, just a bunch of nitpicks.
Tagging @GiacomoPope @grhkm21 who were involved in the previous PR.
src/sage/schemes/weighted_projective/weighted_projective_homset.py
Outdated
Show resolved
Hide resolved
src/sage/schemes/weighted_projective/weighted_projective_space.py
Outdated
Show resolved
Hide resolved
src/sage/schemes/weighted_projective/weighted_projective_space.py
Outdated
Show resolved
Hide resolved
| sage: WP.change_ring(GF(5)) | ||
| Weighted Projective Space of dimension 2 with weights (1, 3, 1) over Finite Field of size 5 | ||
| """ | ||
| if isinstance(R, Map): |
Member
There was a problem hiding this comment.
It would be nice to include an example of this in the docstring.
Contributor
Author
There was a problem hiding this comment.
actually I find this mathematically questionable. Map of rings induce map of their scheme in opposite direction, right.
src/sage/schemes/weighted_projective/weighted_projective_space.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Vincent Macri <[email protected]>
Contributor
Author
|
Someone else may want to double check the equality comparison logic in case of rings with zero divisor (I haven't). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up #40070
as far as I can tell the fedora:42 failure is irrelevant.
📝 Checklist
⌛ Dependencies