Fix missing file error with sage_getdoc #41071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
force-pushed
the
getdoc-missing-file
branch
from
fc69881 to
2474b2d
Compare
user202729
force-pushed
the
getdoc-missing-file
branch
from
2474b2d to
ed382c1
Compare
|
Documentation preview for this PR (built with commit 5640b02; changes) is ready! 🎉 |
cxzhong
approved these changes
Oct 19, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 26, 2025
sagemathgh-41071: Fix missing file error with sage_getdoc see the newly added test, previously it. The reason this affect users is that if in a shell you type ``` sage: class C: ....: ''' ....: docs ....: ''' sage: C? ``` then you'd get an error. After this change, it prints out something somewhat sensible. (also added as a test) I'm not 100% sure what's a good way out on it be this one. On one hand, you ought to make `sage_getfile` behave the same way as https://docs.python.org/3/library/inspect.html#inspect.getfile; on the other hand it is not documented by https://docs.python.org/3/library/inspect.html#inspect.getfile that it may raise `OSError`, so IPython isn't prepared to deal with it. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41071 Reported by: user202729 Reviewer(s): Chenxin Zhong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see the newly added test, previously it.
The reason this affect users is that if in a shell you type
then you'd get an error. After this change, it prints out something somewhat sensible. (also added as a test)
I'm not 100% sure what's a good way out on it be this one. On one hand, you ought to make
sage_getfilebehave the same way as https://docs.python.org/3/library/inspect.html#inspect.getfile; on the other hand it is not documented by https://docs.python.org/3/library/inspect.html#inspect.getfile that it may raiseOSError, so IPython isn't prepared to deal with it.📝 Checklist
⌛ Dependencies