Skip to content

Conversation

antonio-rojas
Copy link
Contributor

GAP 4.15 causes a few test failures caused mostly by different ordering of group characters and different elements returned for an_element in group algebras, make test pass with both old and new versions.

Copy link

Documentation preview for this PR (built with commit 4b4b745; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@collares
Copy link
Contributor

Not sure if you addressed this already, but it seems that some tests are now really slow:

sage -t --long --warn-long 30.0 --random-seed=48470199707196632862320241923438074047 /nix/store/lcqvpnmfb5p7j07wzxialg4315qv2k1p-sage-src-10.6/src/sage/groups/libgap_morphism.py
**********************************************************************
File "/nix/store/lcqvpnmfb5p7j07wzxialg4315qv2k1p-sage-src-10.6/src/sage/groups/libgap_morphism.py", line 452, in sage.groups.libgap_morphism.GroupMorphism_libgap._call_
Warning: slow doctest:
    f = O.hom([r*x*r_ for x in O.gens()])  # long time (19s on sage.math, 2011)
Test ran for 521.46s cpu, 524.36s wall
Check ran for 0.00s cpu, 0.00s wall
    [209 tests, 524.92s wall]

@antonio-rojas antonio-rojas marked this pull request as draft September 30, 2025 05:20
@antonio-rojas
Copy link
Contributor Author

Not sure if you addressed this already, but it seems that some tests are now really slow:

sage -t --long --warn-long 30.0 --random-seed=48470199707196632862320241923438074047 /nix/store/lcqvpnmfb5p7j07wzxialg4315qv2k1p-sage-src-10.6/src/sage/groups/libgap_morphism.py
**********************************************************************
File "/nix/store/lcqvpnmfb5p7j07wzxialg4315qv2k1p-sage-src-10.6/src/sage/groups/libgap_morphism.py", line 452, in sage.groups.libgap_morphism.GroupMorphism_libgap._call_
Warning: slow doctest:
    f = O.hom([r*x*r_ for x in O.gens()])  # long time (19s on sage.math, 2011)
Test ran for 521.46s cpu, 524.36s wall
Check ran for 0.00s cpu, 0.00s wall
    [209 tests, 524.92s wall]

By "now" do you mean with GAP 4.15? This PR only changes the expected output of some tests

@collares
Copy link
Contributor

collares commented Sep 30, 2025

Yes, sorry, I should have been more clear. The test I mentioned seems to be a lot slower on GAP 4.15 than it was on GAP 4.14. More specifically, testing src/sage/groups/libgap_morphism.py goes from 3 seconds on GAP 4.14 to at least 460 seconds (minimum of three runs) on GAP 4.15, and it doesn't seem to be seed-specific.

@antonio-rojas
Copy link
Contributor Author

Yes, sorry, I should have been more clear. The test I mentioned seems to be a lot slower on GAP 4.15 than it was on GAP 4.14. More specifically, testing src/sage/groups/libgap_morphism.py goes from 3 seconds on GAP 4.14 to at least 460 seconds (minimum of three runs) on GAP 4.15, and it doesn't seem to be seed-specific.

Indeed. I have reported it upstream at gap-system/gap#6135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants