Skip to content

some -> bool annotations for is_a* methods #40915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

some -> bool annotations for is_a* methods #40915

wants to merge 1 commit into from

Conversation

fchapoton
Copy link
Contributor

mostly about "is_abelian", "is_absolute" and "is_affine"

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 2dcffba; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vincentmacri
vincentmacri approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! For functions that always return the same thing you can give a slightly more specific annotation with Literal, but it's fine if you want to leave that for future work and not do it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vincentmacri vincentmacri vincentmacri approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
s: positive review t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fchapoton @vincentmacri