moving two methods to the categories of rings and fields #40392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchapoton
changed the title
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 14, 2025
…ields as another step towards getting rid of the auld `Ring` class. - epsilon method to Rings : This method is apparently not used anywhere inside sage. Let's assume it may be used somewhere outside in the wild. - an_embedding method to Fields - also removing a duplicate method in the category of Fields ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40392 Reported by: Frédéric Chapoton Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as another step towards getting rid of the auld
Ringclass.epsilon method to Rings : This method is apparently not used anywhere inside sage. Let's assume it may be used somewhere outside in the wild.
an_embedding method to Fields
also removing a duplicate method in the category of Fields
📝 Checklist