src/sage/geometry/cone.py: speed up a random_cone() test #40384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two random_cone() tests that test hard-to-reach code paths. Usually these will run for a long time, until we get lucky. But testing these code paths does not actually require randomization -- we need only a random seed that triggers the desired path. This commit combines the two slow tests, and chooses a random seed (for those tests only) that makes them succeed quickly.
|
Looks reasonable, can set to good once tests pass. (currently the documentation build CI fails, but this part is only in the test anyway i.e. no documentation change) |
|
Thanks, the one failing CI is unrelated: |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 14, 2025
sagemathgh-40384: src/sage/geometry/cone.py: speed up a random_cone() test We have two `random_cone()` tests that test hard-to-reach code paths. Usually these will run for a long time, until we get lucky. But testing these code paths does not actually require randomization -- we need only a random seed that triggers the desired path. This commit combines the two slow tests, and chooses a random seed (for those tests only) that makes them succeed quickly. URL: sagemath#40384 Reported by: Michael Orlitzky Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two
random_cone()tests that test hard-to-reach code paths. Usually these will run for a long time, until we get lucky. But testing these code paths does not actually require randomization -- we need only a random seed that triggers the desired path. This commit combines the two slow tests, and chooses a random seed (for those tests only) that makes them succeed quickly.